You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/12/16 17:26:38 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-509 Introduce a new REST...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/542
ZEPPELIN-509 Introduce a new REST API: get notebook information
### What is this PR for?
To add a new feature - "get notebook information" via REST API.
### What type of PR is it?
Feature
### Todos
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-509
### How should this be tested?
Just request ```http://<zeppelin host>:<zeppelin port>/api/notebook/<notebookId>```.
If it exists, response would be http status 200 with json body including paragraphs information.
If it doesn't exist, response would be http status 400.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? (No)
* Is there breaking changes for older versions? (No, it's a new feature.)
* Does this needs documentation? (Yes, I've addressed it.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/incubator-zeppelin ZEPPELIN-509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit f63c4fd11844ed3b70e6aa17413d2cf6ec8230bd
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-12-16T16:13:22Z
ZEPPELIN-509 Introduce a new REST API: get notebook information
* Added REST API version of "get notebook information" based on websocket implementation
* Added unit test to test this feature
* Added description of "get notebook information" to rest-notebook.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-509 Introduce a new REST...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/542#issuecomment-165339941
Ready to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-509 Introduce a new REST...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/542#issuecomment-166167461
CI failing is irrelevant to this PR.
LGTM.
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-509 Introduce a new REST...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---