You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/28 04:17:44 UTC
[GitHub] [shardingsphere] mabaiwan opened a new pull request, #18649: Fix loading table metadata error
mabaiwan opened a new pull request, #18649:
URL: https://github.com/apache/shardingsphere/pull/18649
Fixes #18614.
Changes proposed in this pull request:
- Fix loading table metadata error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #18649: Fix loading table metadata error
Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #18649:
URL: https://github.com/apache/shardingsphere/pull/18649#discussion_r908062511
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/MySQLSchemaMetaDataLoader.java:
##########
@@ -125,6 +125,9 @@ private void appendDataTypes(final Map<String, Integer> dataTypes) {
dataTypes.putIfAbsent("JSON", Types.LONGVARCHAR);
dataTypes.putIfAbsent("GEOMETRY", Types.BINARY);
dataTypes.putIfAbsent("YEAR", Types.DATE);
+ dataTypes.putIfAbsent("MULTIPOINT", -2);
Review Comment:
@mabaiwan Hi, Thank you for your pull reqeust. Can you add unit test for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] mabaiwan commented on a diff in pull request #18649: Fix loading table metadata error
Posted by GitBox <gi...@apache.org>.
mabaiwan commented on code in PR #18649:
URL: https://github.com/apache/shardingsphere/pull/18649#discussion_r908289621
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/MySQLSchemaMetaDataLoader.java:
##########
@@ -125,6 +125,9 @@ private void appendDataTypes(final Map<String, Integer> dataTypes) {
dataTypes.putIfAbsent("JSON", Types.LONGVARCHAR);
dataTypes.putIfAbsent("GEOMETRY", Types.BINARY);
dataTypes.putIfAbsent("YEAR", Types.DATE);
+ dataTypes.putIfAbsent("MULTIPOINT", -2);
Review Comment:
of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #18649: Fix loading table metadata error
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #18649:
URL: https://github.com/apache/shardingsphere/pull/18649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org