You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/03/26 16:09:57 UTC
Re: Review Request 66248: Removed SlaveTest.ChangeDomain.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/
-----------------------------------------------------------
(Updated March 26, 2018, 4:09 p.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Removed SlaveTest.ChangeDomain.
Bugs: MESOS-8711
https://issues.apache.org/jira/browse/MESOS-8711
Repository: mesos
Description (updated)
-------
This test was originally written with the assumption that the
would give get a new agent id after receiving a Shutdown
message from the master.
When that behaviour was changed, the test was disabled since
the agent could not reuse the previous agent id when a fault
domain was added.
With the introduction of reconfiguration policies, this feature
is now tested by SlaveTest.ReconfigurationPolicy, making this test
obsolete.
Diffs (updated)
-----
src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c
Diff: https://reviews.apache.org/r/66248/diff/2/
Changes: https://reviews.apache.org/r/66248/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 66248: Removed SlaveTest.ChangeDomain.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/#review199984
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66248]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 26, 2018, 4:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66248/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 4:09 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8711
> https://issues.apache.org/jira/browse/MESOS-8711
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was originally written with the assumption that the
> would give get a new agent id after receiving a Shutdown
> message from the master.
>
> When that behaviour was changed, the test was disabled since
> the agent could not reuse the previous agent id when a fault
> domain was added.
>
> With the introduction of reconfiguration policies, this feature
> is now tested by SlaveTest.ReconfigurationPolicy, making this test
> obsolete.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c
>
>
> Diff: https://reviews.apache.org/r/66248/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 66248: Removed SlaveTest.ChangeDomain.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/#review199982
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66248']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66248
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66248/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (110 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1077 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (41 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (807 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (833 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (861 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (447888 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66248/logs/mesos-tests-stderr.log):
```
I0326 17:04:26.786562 6836 master.cpp:10446] Updating the state of task 8cc91d90-0146-48fa-9567-73d8a185a219 of framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0326 17:04:26.786562 13088 slave.cpp:3873] Shutting down framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000
I0326 17:04:26.787575 13088 slave.cpp:6566] Shutting down executor '8cc91d90-0146-48fa-9567-73d8a185a21I0326 17:04:26.605576 12752 exec.cpp:162] Version: 1.6.0
I0326 17:04:26.632555 12552 exec.cpp:236] Executor registered on agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0
I0326 17:04:26.637543 7324 executor.cpp:176] Received SUBSCRIBED event
I0326 17:04:26.642560 7324 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0326 17:04:26.642560 7324 executor.cpp:176] Received LAUNCH event
I0326 17:04:26.647560 7324 executor.cpp:648] Starting task 8cc91d90-0146-48fa-9567-73d8a185a219
I0326 17:04:26.725563 7324 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0326 17:04:26.760558 7324 executor.cpp:661] Forked command at 4004
I0326 17:04:26.789572 5860 exec.cpp:445] Executor asked to shutdown
I0326 17:04:26.789572 5108 executor.cpp:176] Received SHUTDOWN event
I0326 17:04:26.790560 5108 executor.cpp:758] Shutting down
I0326 17:04:26.790560 5108 executor.cpp:868] Sending SIGTERM to process tree at pid 49' of framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000 at executor(1)@10.3.1.8:57680
I0326 17:04:26.788573 13088 slave.cpp:919] Agent terminating
W0326 17:04:26.788573 13088 slave.cpp:3869] Ignoring shutdown framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000 because it is terminating
I0326 17:04:26.789572 6836 master.cpp:10545] Removing task 8cc91d90-0146-48fa-9567-73d8a185a219 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000 on agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0 at slave(418)@10.3.1.8:57659 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 17:04:26.791563 6836 master.cpp:1295] Agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0 at slave(418)@10.3.1.8:57659 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0326 17:04:26.791563 6836 master.cpp:3283] Disconnecting agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0 at slave(418)@10.3.1.8:57659 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 17:04:26.792565 11940 containerizer.cpp:2338] Destroying container aab47e4b-cf4c-4935-bc5c-a69c6f317aa5 in RUNNING state
I0326 17:04:26.792565 6836 master.cpp:3302] Deactivating agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0 at slave(418)@10.3.1.8:57659 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0326 17:04:26.792565 11940 containerizer.cpp:2952] Transitioning the state of container aab47e4b-cf4c-4935-bc5c-a69c6f317aa5 from RUNNING to DESTROYING
I0326 17:04:26.793563 6868 hierarchical.cpp:344] Removed framework 86e053f4-c315-49d9-9112-2634ae24bc00-0000
I0326 17:04:26.793563 6868 hierarchical.cpp:766] Agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0 deactivated
I0326 17:04:26.793563 11940 launcher.cpp:156] Asked to destroy container aab47e4b-cf4c-4935-bc5c-a69c6f317aa5
I0326 17:04:26.872391 8148 containerizer.cpp:2791] Container aab47e4b-cf4c-4935-bc5c-a69c6f317aa5 has exited
I0326 17:04:26.906414 11644 master.cpp:1137] Master terminating
I0326 17:04:26.909430 3928 hierarchical.cpp:609] Removed agent 86e053f4-c315-49d9-9112-2634ae24bc00-S0
I0326 17:04:27.295459 12740 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 26, 2018, 9:09 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66248/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 9:09 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8711
> https://issues.apache.org/jira/browse/MESOS-8711
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was originally written with the assumption that the
> would give get a new agent id after receiving a Shutdown
> message from the master.
>
> When that behaviour was changed, the test was disabled since
> the agent could not reuse the previous agent id when a fault
> domain was added.
>
> With the introduction of reconfiguration policies, this feature
> is now tested by SlaveTest.ReconfigurationPolicy, making this test
> obsolete.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c
>
>
> Diff: https://reviews.apache.org/r/66248/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 66248: Removed SlaveTest.ChangeDomain.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/#review199983
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 26, 2018, 4:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66248/
> -----------------------------------------------------------
>
> (Updated March 26, 2018, 4:09 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-8711
> https://issues.apache.org/jira/browse/MESOS-8711
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was originally written with the assumption that the
> would give get a new agent id after receiving a Shutdown
> message from the master.
>
> When that behaviour was changed, the test was disabled since
> the agent could not reuse the previous agent id when a fault
> domain was added.
>
> With the introduction of reconfiguration policies, this feature
> is now tested by SlaveTest.ReconfigurationPolicy, making this test
> obsolete.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c
>
>
> Diff: https://reviews.apache.org/r/66248/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>