You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by nwellnhof <gi...@git.apache.org> on 2015/05/29 18:50:46 UTC
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-52 Implement To_Host method...
GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-clownfish/pull/25
CLOWNFISH-52 Implement To_Host methods for core types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-clownfish CLOWNFISH-52-to-host
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit e702b2722850a1070fe05f108d85b02da4d35c22
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T11:44:31Z
Rework test for invalid callbacks
The old test relied on To_Host being called from the constructor.
Add a custom test class to invoke an invalid callback from C.
commit 7bceed1d72ab4d0a97426a4003066fe42403344b
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T10:56:43Z
Implement To_Host for Nums
commit 7a4aeb9989c9b15e23cec8298233aac2ba355b22
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T11:49:42Z
Avoid unwanted calls to To_Host
Make sure that Perl constructors and XSBind_cfish_obj_to_sv don't
invoke To_Host but always return a reference to a Clownfish::Obj.
Don't call To_Host when mortalizing objects converted from Perl arrays
and hashes.
commit dc82fc54c3faf929b271fca886feab9fb02e06da
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T11:53:05Z
Implement Hash_To_Host
commit c7176523871d496d08e17de4d7822783c98426f3
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T11:58:00Z
Implement Vec_To_Host
commit eadeae084ace20abe0d5ef7d6b01d44e04567dcd
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T12:10:18Z
Implement BB_To_Host
commit 40d863c7e1bcaf1db0b08d8c88ab7ba50c4dde7b
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T12:26:13Z
Implement Blob_To_Host
commit 4afe9a6bcc3c8a0c74c7a042bea582d5db80fe58
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T12:43:16Z
Implement Str_To_Host
commit e5435615d8f8a0132608fd9d90935b62a4f2f995
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T12:59:43Z
Make XSBind_cfish_to_perl inline
Now XSBind_cfish_to_perl is nothing more than a null-safe wrapper
around Obj_To_Host.
commit d448dd7f44d53d7ca960a7d2312a644de1b87093
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T16:10:32Z
Implement To_Host methods for C bindings
commit 04e73fac39f178d125c99b5079b1fbf7fb491629
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2015-05-29T16:49:24Z
Implement To_Host methods for Go bindings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-52
Implement To_Host method...
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Fri, May 29, 2015 at 9:50 AM, nwellnhof <gi...@git.apache.org> wrote:
> GitHub user nwellnhof opened a pull request:
>
> https://github.com/apache/lucy-clownfish/pull/25
>
> CLOWNFISH-52 Implement To_Host methods for core types
Looks great! +1 to merge.
> Now XSBind_cfish_to_perl is nothing more than a null-safe wrapper
> around Obj_To_Host.
Nice.
Marvin Humphrey
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-52 Implement To_Host method...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---