You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/08/29 08:32:27 UTC
[GitHub] diecui1202 commented on a change in pull request #2357:
[Dubbo-#1293][Baiji-9]fix the issue #1293
diecui1202 commented on a change in pull request #2357: [Dubbo-#1293][Baiji-9]fix the issue #1293
URL: https://github.com/apache/incubator-dubbo/pull/2357#discussion_r213589266
##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ReferenceConfigCache.java
##########
@@ -149,5 +202,6 @@ public String toString() {
public static interface KeyGenerator {
String generateKey(ReferenceConfig<?> referenceConfig);
+ String generateKey(String version,String url,String name);
Review comment:
Why the parameters are version, url and name? not interfaceName, group and version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org