You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2016/08/04 07:46:22 UTC
[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1625
[blocker] cloudstack: fix upgrade paths to 4.10.0
This adds an upgrade to master since the recent 4.9 cut, adds an upgrade path to the new code version 4.10. Without this PR all PRs to master are failing due to missing upgrade path. Please merge this on priority.
Code review and Travis results should be enough to validate the changes.
/cc @karuturi @wido @ProjectMoon @abhinandanprateek
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack dbupgrade-fix-4.10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit 546a3f8884398391760b76ddcf02e6bc1f30d642
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-08-04T07:33:46Z
cloudstack: fix upgrade paths to 4.10.0
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1625
yup... started testing.. in progress.. will be done probably in 30 min..
you started automation run.. should we wait for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Looks like this unit test failed: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.773 sec <<< FAILURE! - in org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
I've seen this unit test fail sometimes, any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
The unit test again failed with Travis:
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.821 sec <<< FAILURE! - in org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
<span>Holy monkeys!</span> <b>Failed</b> to build one or more CloudStack packages that would have been available at: http://packages.shapeblue.com/cloudstack/custom/github-1625.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Holy monkeys! Failed to build one or more CloudStack packages that would have been available at: http://packages.shapeblue.com/cloudstack/custom/github-1625.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@karuturi on the machine which was building the rpm packages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Thanks @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@karuturi our Trillian job has hit an internal bug so the job died, nevertheless a single run could take hours against real hypervisors (we've xen, kvm and vmware). I'll keep you posted when we've got that fixed and the PR-testing pipeline fixed. Meanwhile, we can consider Travis and your test results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@blueorangutan the link doesnt work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
I'm able to consistently reproduce the unit test failure on a machine with similar memory as Travis (~8GB RAM):
searchForExistingLoadBalancer(org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest) Time elapsed: 2.774 sec <<< ERROR!
java.lang.IllegalStateException: Failed to load ApplicationContext
at org.springframework.test.context.CacheAwareContextLoaderDelegate.loadContext(CacheAwareContextLoaderDelegate.java:103)
at org.springframework.test.context.TestContext.getApplicationContext(TestContext.java:122)
at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:109)
at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:75)
at org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:321)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.createTest(SpringJUnit4ClassRunner.java:211)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner$1.runReflectiveCall(SpringJUnit4ClassRunner.java:288)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.methodBlock(SpringJUnit4ClassRunner.java:284)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:88)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:71)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:174)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to read candidate component class: file [/var/jenkins/workspace/cloudstack-pr/server/target/classes/org/apache/cloudstack/network/lb/CertServiceImpl.class]; nested exception is java.lang.OutOfMemoryError: PermGen space
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1625
code looks good.
I am seeing the following travis errors
`[ERROR] Failed to execute goal on project travis-build-deps: Could not resolve dependencies for project org.apache.cloudstack:travis-build-deps:jar:1: Failure to find net.nuage.vsp:nuage-vsp-acs-client:jar:3.2.8.0 in http://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of Central has elapsed or updates are forced -> [Help 1]`
`[ERROR] Failed to execute goal on project cloud-developer: Could not resolve dependencies for project org.apache.cloudstack:cloud-developer:pom:4.10.0-SNAPSHOT: Could not find artifact org.apache.cloudstack:cloud-server:jar:4.10.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]`
Can you force push please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Looks like this unit test is known to consume a lot of memory: Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.918 sec - in org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
java.lang.OutOfMemoryError: PermGen space
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-1625. Initiating automated testing with Trillian shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@karuturi all green now, can we merge this? /cc @jburwell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-1625. Initiating automated testing with Trillian shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
<span style='color:red'>Holy monkeys!</span> <b style='color:#f00'>Failed</b> to build one or more CloudStack packages that would have been available at: http://packages.shapeblue.com/cloudstack/custom/github-1625.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@karuturi that's a bot account that will do packaging and testing for us soon, I was testing it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-. Initiating automated testing with Trillian shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1625
[blocker] cloudstack: fix upgrade paths to 4.10.0
This adds an upgrade to master since the recent 4.9 cut, adds an upgrade path to the new code version 4.10. Without this PR all PRs to master are failing due to missing upgrade path. Please merge this on priority.
Code review and Travis results should be enough to validate the changes.
/cc @karuturi @wido @ProjectMoon @abhinandanprateek
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack dbupgrade-fix-4.10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit 546a3f8884398391760b76ddcf02e6bc1f30d642
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-08-04T07:33:46Z
cloudstack: fix upgrade paths to 4.10.0
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1625
<span style='color:red'>Holy monkeys!</span> <b>Failed</b> to build one or more CloudStack packages that would have been available at: http://packages.shapeblue.com/cloudstack/custom/github-1625.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1625
@karuturi thanks, I'll have a look why it failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1625
Where did you see the OOM error? I dont see it in travis logs
(this is for the previous travis job) https://s3.amazonaws.com/archive.travis-ci.org/jobs/149684289/log.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---