[GitHub] [doris] morrySnow commented on a diff in pull request #16061: [fix](nereids) do not generate compare between Date to Date

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #16061:
URL: https://github.com/apache/doris/pull/16061#discussion_r1073402446


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/SimplifyComparisonPredicate.java:
##########
@@ -111,13 +113,56 @@ private Expression processDateLikeTypeCoercion(ComparisonPredicate cp, Expressio
             }
         }
 
+        if (left.getDataType() == DateType.INSTANCE && right.getDataType() == DateType.INSTANCE) {

Review Comment:
   do storage engine support date slot compare with datetime?
   if it support, we could avoid add cast on the slot
   and then, this expression could push down to storage engine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org