[GitHub] [airflow] potiuk commented on issue #17490: KubernetesJobOperator

[GitBox <gi...@apache.org>]

potiuk commented on issue #17490:
URL: https://github.com/apache/airflow/issues/17490#issuecomment-894741110


   I believe (and please.correcr me if I am wrong) that pod_template_file parameter of the KubernetesPodOperator already handles what you wanted to implement - including possibility of generating the template file via cli of airflow and integration with Ninja templating of Airflow). 
   
   This has been added relatively recently to the operator (Autumn last year) and the Python-object approach is recommended only if you have relatively simple Pod to fire,  so you might have not noticed it. For any more complex /sophisticated uses of the operator pod_template file is recommended.
   
   People are already not very clear when they should use KubernetesExecutor vs KunernetesPodOperator, so adding yet another option is I think not a good idea.
   
   Are there any features that you thought about not possible to do with KPO /pod_template_file ? If so i think it would be better to rather add those to the KPO rather than create a new entity.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org