You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by ga...@gmail.com on 2010/07/24 05:48:55 UTC
Fixing small error in PropertiesModule (issue1883042)
Reviewers: dev-remailer_shindig.apache.org,
Please review this at http://codereview.appspot.com/1883042/show
Affected files:
java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
Index:
java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
===================================================================
---
java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
(revision 978785)
+++
java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
(working copy)
@@ -81,7 +81,7 @@
protected String getServerHostname() {
return System.getProperty("shindig.host") != null ?
System.getProperty("shindig.host") :
- return System.getProperty("jetty.host") != null ?
System.getProperty("jetty.host") :
+ System.getProperty("jetty.host") != null ?
System.getProperty("jetty.host") :
"localhost";
}
Re: Fixing small error in PropertiesModule (issue1883042)
Posted by Gagandeep singh <ga...@gmail.com>.
Thanks Paul
On Sat, Jul 24, 2010 at 9:42 AM, Paul Lindner <pl...@linkedin.com> wrote:
> I broke this, but was, waiting for apache svn to go read/write... It's
> back now -- committed.
>
>
> On Fri, Jul 23, 2010 at 8:48 PM, <ga...@gmail.com> wrote:
>
>> Reviewers: dev-remailer_shindig.apache.org,
>>
>>
>>
>> Please review this at http://codereview.appspot.com/1883042/show
>>
>> Affected files:
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>>
>>
>> Index:
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> ===================================================================
>> ---
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> (revision 978785)
>> +++
>> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>> (working copy)
>> @@ -81,7 +81,7 @@
>>
>> protected String getServerHostname() {
>> return System.getProperty("shindig.host") != null ?
>> System.getProperty("shindig.host") :
>> - return System.getProperty("jetty.host") != null ?
>> System.getProperty("jetty.host") :
>> + System.getProperty("jetty.host") != null ?
>> System.getProperty("jetty.host") :
>> "localhost";
>> }
>>
>>
>>
>>
>
Re: Fixing small error in PropertiesModule (issue1883042)
Posted by Paul Lindner <pl...@linkedin.com>.
I broke this, but was, waiting for apache svn to go read/write... It's back
now -- committed.
On Fri, Jul 23, 2010 at 8:48 PM, <ga...@gmail.com> wrote:
> Reviewers: dev-remailer_shindig.apache.org,
>
>
>
> Please review this at http://codereview.appspot.com/1883042/show
>
> Affected files:
> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
>
>
> Index:
> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
> ===================================================================
> ---
> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
> (revision 978785)
> +++
> java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java
> (working copy)
> @@ -81,7 +81,7 @@
>
> protected String getServerHostname() {
> return System.getProperty("shindig.host") != null ?
> System.getProperty("shindig.host") :
> - return System.getProperty("jetty.host") != null ?
> System.getProperty("jetty.host") :
> + System.getProperty("jetty.host") != null ?
> System.getProperty("jetty.host") :
> "localhost";
> }
>
>
>
>