You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/07 17:24:47 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #19952: Optimize code according to code analyze
RaigorJiang opened a new pull request, #19952:
URL: https://github.com/apache/shardingsphere/pull/19952
- Simplify lambda expressions
- Update the call to BigDecimal.setScale (the original method has been deprecated)
- Improve readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19952: Optimize code according to code analyze
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19952:
URL: https://github.com/apache/shardingsphere/pull/19952#issuecomment-1207458293
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19952](https://codecov.io/gh/apache/shardingsphere/pull/19952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06ff16a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aa254d008fcebce9566e619d65a6b803d4c160cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa254d0) will **increase** coverage by `0.01%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #19952 +/- ##
============================================
+ Coverage 60.15% 60.16% +0.01%
Complexity 2422 2422
============================================
Files 3882 3882
Lines 55082 55078 -4
Branches 7706 7706
============================================
+ Hits 33132 33136 +4
+ Misses 19108 19100 -8
Partials 2842 2842
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...esher/type/AlterTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclRhYmxlU3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | `7.40% <0.00%> (+0.51%)` | :arrow_up: |
| [...resher/type/AlterViewStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclZpZXdTdGF0ZW1lbnRTY2hlbWFSZWZyZXNoZXIuamF2YQ==) | `7.14% <0.00%> (+0.47%)` | :arrow_up: |
| [...l/prepare/driver/DriverExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9Ecml2ZXJFeGVjdXRpb25QcmVwYXJlRW5naW5lLmphdmE=) | `0.00% <ø> (ø)` | |
| [...eline/core/ingest/channel/memory/ManualBitSet.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L2NoYW5uZWwvbWVtb3J5L01hbnVhbEJpdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ess/persist/PipelineJobProgressPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvam9iL3Byb2dyZXNzL3BlcnNpc3QvUGlwZWxpbmVKb2JQcm9ncmVzc1BlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...peline/mysql/ingest/client/PasswordEncryption.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NsaWVudC9QYXNzd29yZEVuY3J5cHRpb24uamF2YQ==) | `91.17% <ø> (ø)` | |
| [...nd/postgresql/command/query/PostgreSQLCommand.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L1Bvc3RncmVTUUxDb21tYW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../ddl/impl/ShardingDropTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0Ryb3BUYWJsZVN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `88.88% <100.00%> (ø)` | |
| [...sher/type/RenameTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9SZW5hbWVUYWJsZVN0YXRlbWVudFNjaGVtYVJlZnJlc2hlci5qYXZh) | `92.00% <100.00%> (+6.81%)` | :arrow_up: |
| [...uery/impl/driver/jdbc/type/util/ResultSetUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL3Jlc3VsdC9xdWVyeS9pbXBsL2RyaXZlci9qZGJjL3R5cGUvdXRpbC9SZXN1bHRTZXRVdGlsLmphdmE=) | `81.37% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/19952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo merged pull request #19952: Optimize code according to code analyze
Posted by GitBox <gi...@apache.org>.
totalo merged PR #19952:
URL: https://github.com/apache/shardingsphere/pull/19952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org