You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/10/15 21:10:00 UTC

[jira] [Commented] (MNG-7910) DefaultProfileSelector empty ctor uses immutable list

    [ https://issues.apache.org/jira/browse/MNG-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775504#comment-17775504 ] 

ASF GitHub Bot commented on MNG-7910:
-------------------------------------

cstamas opened a new pull request, #1283:
URL: https://github.com/apache/maven/pull/1283

   It uses immutable list and while it suggests it allows this below, it actually fails on constructs like this (runtime ONLY): {noformat}
   new DefaultProfileSelector()
                   .addProfileActivator(new JdkVersionProfileActivator())
                   .addProfileActivator(new PropertyProfileActivator())
   {noformat}
   
   As default ctor creates immutable list, but API kinda suggests this is ok.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7910




> DefaultProfileSelector empty ctor uses immutable list
> -----------------------------------------------------
>
>                 Key: MNG-7910
>                 URL: https://issues.apache.org/jira/browse/MNG-7910
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 4.0.0-alpha-7
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0-alpha-8
>
>
> It uses immutable list and while it looks it allows, actually fails on constructs like this:
> {noformat}
> new DefaultProfileSelector()
>                 .addProfileActivator(new JdkVersionProfileActivator())
>                 .addProfileActivator(new PropertyProfileActivator())
> {noformat}
> As default ctor creates immutable list, but API kinda suggests this is ok.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)