Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

[Daniel Shahaf <da...@elego.de>]

Thanks for the patches.

Matthijs Kooijman wrote on Thu, Jan 05, 2012 at 21:06:19 +0100:
> Patches are against svn trunk (r1227522), but also apply with just a
> single trivial conflict to 1.6.17.

> [[[
> Fix the get-location-segments.py example
> 
> When trying to run the example, it throws:
> 
>     TypeError: Unexpected NULL parent pool on proxy object
> 
> Somehow, the "_parent_pool" property wasn't initialized on the context.
> Not sure how this works, but creating a context using
> client.svn_client_create_context() instead of client.ctx_t() (which
> subversion/bindings/swig/python/tests/pool.py also does) fixes this
> error and makes the example work again.
> 
> * tools/examples/get-location-segments.py
>   Use client.svn_client_create_context instead of client.ctx_t.
> 
> Patch by: Matthijs Kooijman <ma...@stdin.nl>
> ]]]
> Index: subversion-trunk/tools/examples/get-location-segments.py
> ===================================================================
> --- subversion-trunk.orig/tools/examples/get-location-segments.py	2012-01-05 14:29:12.146977757 +0100
> +++ subversion-trunk/tools/examples/get-location-segments.py	2012-01-05 14:31:20.179645368 +0100
> @@ -124,7 +124,7 @@
>      sys.exit(1)
>  
>    core.svn_config_ensure(None)
> -  ctx = client.ctx_t()
> +  ctx = client.svn_client_create_context()

This looks trivial so I'll apply it, but I'd like to note that
'patch -p1' rejects this for some reason.

>    providers = [
>      client.get_simple_provider(),
>      core.svn_auth_get_ssl_server_trust_file_provider(),

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

[Daniel Shahaf <da...@elego.de>]

Matthijs Kooijman wrote on Sun, Jan 08, 2012 at 17:37:02 +0100:
> Perhaps this is a CRLF vs LF issue? I see the file in question has
> svn:eol-style=native. I'm running on Linux, perhaps you're running on
> Windows?

Nope.  Linux and/or FreeBSD.

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

[Matthijs Kooijman <ma...@stdin.nl>]

Hey Daniel,

> This looks trivial so I'll apply it,
Thanks.

> but I'd like to note that 'patch -p1' rejects this for some reason.
Weird, it workd for me. Patches were created using quilt, but that
shouldn't matter I guess.

Perhaps this is a CRLF vs LF issue? I see the file in question has
svn:eol-style=native. I'm running on Linux, perhaps you're running on
Windows?

Gr.

Matthijs