[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #1273: [NETBEANS-2614, NETBEANS-1586] Improve icon scaling on HiDPI displays, and prepare ImageUtilities for HiDPI icons

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #1273: [NETBEANS-2614,NETBEANS-1586] Improve icon scaling on HiDPI displays, and prepare ImageUtilities for HiDPI icons
URL: https://github.com/apache/netbeans/pull/1273#discussion_r289592374
 
 

 ##########
 File path: java/jshell.support/src/org/netbeans/modules/jshell/editor/CommandCompletionProvider.java
 ##########
 @@ -337,7 +337,7 @@ protected ImageIcon getIcon() {
                             n = f.getLookup().lookup(Node.class);
                         }
                         if (n != null) {
-                            return (ImageIcon)ImageUtilities.image2Icon(n.getIcon(BeanInfo.ICON_COLOR_16x16));
+                            return new ImageIcon(n.getIcon(BeanInfo.ICON_COLOR_16x16));
 
 Review comment:
   Suspicious. Nobody shall instantiate icons. Code should call into `ImageUtilities` all the time, I believe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists