You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by franckcuny <gi...@git.apache.org> on 2016/08/17 03:31:10 UTC

[GitHub] incubator-distributedlog pull request #12: DL-32: Update findbugs version to...

GitHub user franckcuny opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/12

    DL-32: Update findbugs version to 3.0.3

    The previous version (2.5.2) is not compatible with Java 8.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franckcuny/incubator-distributedlog fcuny/DL-32

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12
    
----
commit 74f85a4ee9fd105bfbbf0e7acbf31fffb6f7db75
Author: Franck Cuny <fc...@apache.org>
Date:   2016-08-17T03:27:38Z

    DL-32: Update findbugs version to 3.0.3
    
    The previous version (2.5.2) is not compatible with Java 8.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog pull request #12: DL-32: Update findbugs version to...

Posted by franckcuny <gi...@git.apache.org>.
Github user franckcuny closed the pull request at:

    https://github.com/apache/incubator-distributedlog/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

Posted by franckcuny <gi...@git.apache.org>.
Github user franckcuny commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/12
  
    I'm unable to run successfully `mvn findbugs:findbugs` at the moment, I keep hitting this issue:
    
    ```
    [ERROR] Failed to execute goal on project distributedlog-core: Could not resolve dependencies for project com.twitter:distributedlog-core:jar:0.3.51-SNAPSHOT: Could not find artifact com.twitter:distributedlog-protocol:jar:0.3.51-SNAPSHOT in bookkeeper-twitter-mvn-repo (https://raw.github.com/twitter/bookkeeper/mvn-repo/4.3.5-TWTTR-OSS) -> [Help 1]
    ```
    
    It looks like the name on GitHub is RELEASE4.3.5-TWTTR-OSS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/12
  
    @franckcuny I think findbugs was added in #19 . mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/12
  
    Also, I think we also need to make code changes to address findbugs errors if there are any.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #12: DL-32: Update findbugs version to 3.0.3

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/12
  
    @franckcuny I think you might need to run `mvn clean install -DskipTests` first and then run `mvn findbugs:findbugs`. `Findbugs` runs when the code is compiled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---