[jira] [Commented] (KAFKA-6740) Plugins class' newConverter and newHeaderConverter methods are unclear

["Randall Hauch (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423496#comment-16423496 ] 

Randall Hauch commented on KAFKA-6740:
--------------------------------------

See an earlier fix to these methods.

> Plugins class' newConverter and newHeaderConverter methods are unclear
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-6740
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6740
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 1.1.0
>            Reporter: Randall Hauch
>            Priority: Major
>
> The ClassLoaderUsage enum is a bit unclear as to what the code is doing. The `CURRENT_CLASSLOADER` is really about using the connector's configuration, whereas the `PLUGINS` literal is more about using the worker's configuration. We should clean this up, and we should also look at moving the if-block into the `CURRENT_CLASSLOADER` case in {{newConverter}}, just as we did in the {{newHeaderConverter}} method in KAFKA-6728.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)