You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by tilaks26 <gi...@git.apache.org> on 2017/07/04 16:59:22 UTC
[GitHub] airavata-php-gateway pull request #64: [AIRAVATA-2477] Modifying generation ...
GitHub user tilaks26 opened a pull request:
https://github.com/apache/airavata-php-gateway/pull/64
[AIRAVATA-2477] Modifying generation of the password token
The identity server password token is generated by storing the username and password provided in the credential store and retrieving the credential store token.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tilaks26/airavata-php-gateway 2477
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata-php-gateway/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 944ffea4d3e8574ababd458444c214b61fd3bacc
Author: Sneha Tilak <ti...@snehas-macbook-pro.local>
Date: 2017-07-04T16:55:50Z
Modifying generation of the password token
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata-php-gateway pull request #64: [AIRAVATA-2477] Modifying generation ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/airavata-php-gateway/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata-php-gateway pull request #64: [AIRAVATA-2477] Modifying generation ...
Posted by machristie <gi...@git.apache.org>.
Github user machristie commented on a diff in the pull request:
https://github.com/apache/airavata-php-gateway/pull/64#discussion_r125534010
--- Diff: app/libraries/AdminUtilities.php ---
@@ -28,7 +28,8 @@ public static function add_gateway($inputs)
$gateway->gatewayAdminEmail = $inputs["admin-email"];
$gateway->gatewayAdminLastName = $inputs["admin-lastname"];
$gateway->identityServerUserName = $inputs["admin-username"];
- $gateway->identityServerPasswordToken = $inputs["admin-password"];
+ $token = create_pwd_token([Session::get('username'), $inputs["admin-password"]]);
--- End diff --
The username should be the admin-username not the logged in user's username.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata-php-gateway pull request #64: [AIRAVATA-2477] Modifying generation ...
Posted by machristie <gi...@git.apache.org>.
Github user machristie commented on a diff in the pull request:
https://github.com/apache/airavata-php-gateway/pull/64#discussion_r125534137
--- Diff: app/libraries/AdminUtilities.php ---
@@ -28,7 +28,8 @@ public static function add_gateway($inputs)
$gateway->gatewayAdminEmail = $inputs["admin-email"];
$gateway->gatewayAdminLastName = $inputs["admin-lastname"];
$gateway->identityServerUserName = $inputs["admin-username"];
- $gateway->identityServerPasswordToken = $inputs["admin-password"];
+ $token = create_pwd_token([Session::get('username'), $inputs["admin-password"]]);
--- End diff --
I think you have to call create_pwd_token like `AdminUtilities::create_pwd_token`. Also the array passed should specify the keys. Something like
```
AdminUtilities::create_pwd_token([
"username" => $inputs["admin-username"],
"password" => $inputs["admin-password"],
"description" => "Admin user password for gateway " . $id
]);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---