[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2124: IGNITE-19593 Optimized update assignments routine to start multiple tables at the same time.

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #2124:
URL: https://github.com/apache/ignite-3/pull/2124#discussion_r1212710045


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1112,11 +1124,7 @@ private CompletableFuture<?> createTableLocally(long causalityToken, String name
         // TODO: IGNITE-19082 Need another way to wait for indexes
         table.addIndexesToWait(collectTableIndexIds(tblId));
 
-        tablesByIdVv.update(causalityToken, (previous, e) -> inBusyLock(busyLock, () -> {
-            if (e != null) {
-                return failedFuture(e);
-            }
-
+        Function<Map<Integer, TableImpl>, CompletableFuture<Map<Integer, TableImpl>>> createTableClosure = previous -> {

Review Comment:
   I reverted this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org