You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/10/12 22:32:15 UTC

[PR] Split CacheVC into its own source file [trafficserver]

JosiahWI opened a new pull request, #10599:
URL: https://github.com/apache/trafficserver/pull/10599

   This is a low-priority cleanup, but it should be easy to review because I only moved code between files and didn't make any source changes, besides taking the time to carefully list out all the includes for the new source file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Split CacheVC into its own source file [trafficserver]

Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760598760

   Also in the CacheVol.cc. Thanks for taking care those.
   https://github.com/apache/trafficserver/blob/2eb6377e8e59ae862c4e0f29aabc139b6f8b1acc/iocore/cache/CacheVol.cc#L62


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Split CacheVC into its own source file [trafficserver]

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760596219

   Good catch. I'll add that to my TODO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Split CacheVC into its own source file [trafficserver]

Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760592237

   We can move these later, but please note that some CacheVC function implementations are still in the CacheRead.cc and CacheWrite.cc.
   
   https://github.com/apache/trafficserver/blob/2eb6377e8e59ae862c4e0f29aabc139b6f8b1acc/iocore/cache/CacheRead.cc#L186
   
   https://github.com/apache/trafficserver/blob/2eb6377e8e59ae862c4e0f29aabc139b6f8b1acc/iocore/cache/CacheWrite.cc#L76


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Split CacheVC into its own source file [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org