You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/16 10:41:00 UTC

[GitHub] [incubator-pekko-http] pjfanning opened a new issue, #63: figure out what to about the shapeless code in the parsing module

pjfanning opened a new issue, #63:
URL: https://github.com/apache/incubator-pekko-http/issues/63

   * Unlike #1, there is no decision to remove the shapeless code yet.
   * it could be that if #1 is merged, that we no longer need the shapeless code (I haven't checked if the parboiled2 code is the only code using the shapeless code)
   * shapeless3 exists for Scala 3 but does include HList - I guess the logic is that Scala 3 tuples can do the task
   * so if we do use HLIst or the other shapeless code in pekko-http (after #1 is merged or deferred) then we might want to keep the shapeless code
   * if we keep it, we will need to consider updating our LICENSE and NOTICE. 
      * https://github.com/milessabin/shapeless has no NOTICE
      * it is Apache licensed so we may need to document it in our license (this needs to be verified) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] mdedetrich commented on issue #63: figure out what to about the shapeless code in the parsing module

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #63:
URL: https://github.com/apache/incubator-pekko-http/issues/63#issuecomment-1432901283

   Regarding Scala 3, Scala has apparently added HLists and other datastructures which shapeless has historically been used for (see https://www.scala-lang.org/2021/02/26/tuples-bring-generic-programming-to-scala-3.html), so one thing we can do is to remove shapeless for Scala 3 specifically


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on issue #63: figure out what to about the shapeless code in the parsing module

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #63:
URL: https://github.com/apache/incubator-pekko-http/issues/63#issuecomment-1442344817

   this code was removed alongside the parboiled code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning closed issue #63: figure out what to about the shapeless code in the parsing module

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #63: figure out what to about the shapeless code in the parsing module
URL: https://github.com/apache/incubator-pekko-http/issues/63


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org