You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/12 13:30:12 UTC
[GitHub] [skywalking-data-collect-protocol] arugal opened a new pull request
#19: Add firstReportedError field
arugal opened a new pull request #19: Add firstReportedError field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19
Concern at https://github.com/apache/skywalking/pull/4228#issuecomment-584992794.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request
#19: Add firstReportedError field
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #19: Add firstReportedError field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change
in pull request #19: Add firstReportedError field
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #19: Add firstReportedError field
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19#discussion_r378298953
##########
File path: browser/BrowserPerf.proto
##########
@@ -45,15 +45,17 @@ message BrowserPerfData {
// Page path in the browser, mostly it is URI, without parameter
string pagePath = 4;
int32 pagePathId = 5;
+ // Then the PV with error is only calculated when firstReportedError is true.
+ bool firstReportedError = 6;
Review comment:
After release, such as 7.0.0, we only add field at the last seq for keeping the compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services