You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/12/12 20:27:04 UTC
[GitHub] [incubator-hop] nadment opened a new pull request #465: Hop 2296
nadment opened a new pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] usbrandon commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
usbrandon commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744159013
I got further, but something else fails about the file selection. For example when I used an Excel Input step (no project, no environment), and just browsed to an Excel file in my home directory, once I clicked OK, then there is a SWT Widget disposed problem.
The following stack trace was present:
java.lang.RuntimeException: Error executing method : editTransform in class org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph
at org.apache.hop.core.gui.plugin.action.GuiActionLambdaBuilder.lambda$createLambda$0(GuiActionLambdaBuilder.java:98)
at org.apache.hop.ui.hopgui.context.GuiContextUtil.handleActionSelection(GuiContextUtil.java:143)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.showActionDialog(HopGuiPipelineGraph.java:1171)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.lambda$mouseUp$1(HopGuiPipelineGraph.java:1039)
at org.eclipse.swt.widgets.Display.runTimer(Display.java:4020)
at org.eclipse.swt.widgets.Display.messageProc(Display.java:3146)
at org.eclipse.swt.internal.win32.OS.DispatchMessage(Native Method)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3522)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:363)
at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:299)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hop.core.gui.plugin.action.GuiActionLambdaBuilder.lambda$createLambda$0(GuiActionLambdaBuilder.java:93)
... 9 more
Caused by: org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.swt.SWTException: Widget is disposed)
at org.eclipse.swt.SWT.error(SWT.java:4723)
at org.eclipse.swt.SWT.error(SWT.java:4638)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:188)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3897)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3527)
at org.apache.hop.ui.core.dialog.ErrorDialog.showErrorDialog(ErrorDialog.java:217)
at org.apache.hop.ui.core.dialog.ErrorDialog.<init>(ErrorDialog.java:95)
at org.apache.hop.ui.core.dialog.ErrorDialog.<init>(ErrorDialog.java:82)
at org.apache.hop.ui.hopgui.file.pipeline.delegates.HopGuiPipelineTransformDelegate.editTransform(HopGuiPipelineTransformDelegate.java:226)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:3176)
at org.apache.hop.ui.hopgui.file.pipeline.HopGuiPipelineGraph.editTransform(HopGuiPipelineGraph.java:2145)
... 14 more
Caused by: org.eclipse.swt.SWTException: Widget is disposed
at org.eclipse.swt.SWT.error(SWT.java:4723)
at org.eclipse.swt.SWT.error(SWT.java:4638)
at org.eclipse.swt.SWT.error(SWT.java:4609)
at org.eclipse.swt.widgets.Widget.error(Widget.java:432)
at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:351)
at org.eclipse.swt.widgets.Tree.setRedraw(Tree.java:4748)
at org.apache.hop.ui.core.widget.TreeUtil.lambda$setOptimalWidthOnColumns$0(TreeUtil.java:30)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
... 22 more
Another small glitch is while browsing to the folder, I happened to have a really long file in one of the directories. The horizontal scroll bar at the bottom would not allow any kind of movement and it seemed like the UI froze for a moment. After the UI became responsive again, I was able to browse for the Excel file I was looking for, and upon selecting it, the above stack trace came out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] usbrandon edited a comment on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
usbrandon edited a comment on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744042016
Your latest push fixed the NPE issue and I can browse into folders. There are some strange things that happen though, for example the window opens with a weird default size (too narrow), but the folder name's are perfect. The column headers flicker into the dialog at the top. --- So it functions, but now a flicker and some additional resizing are required. These headers continue to flicker even after I resize the dialog box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] usbrandon commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
usbrandon commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744034369
Opening the file dialog worked and the column widths looked good. However, I got an NPE when double clicking on a folder.
Windows 10. -- In the current master build of hop before your Pull Request, There is a SWT exception and it also fails.
It gave the following stack trace:
Error browsing to location: C:\Users\usbra\Box
NullPointerException:
Root cause: NullPointerException:
java.lang.NullPointerException
at org.eclipse.swt.widgets.TreeItem.getBounds(TreeItem.java:419)
at org.eclipse.swt.widgets.TreeColumn.pack(TreeColumn.java:371)
at org.apache.hop.ui.core.widget.TreeUtil.setOptimalWidthOnColumns(TreeUtil.java:29)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.resizeTableColumn(HopVfsFileDialog.java:1211)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.lambda$open$7(HopVfsFileDialog.java:465)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1042)
at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5768)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method)
at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1454)
at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5830)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
at org.eclipse.swt.internal.win32.OS.SetScrollInfo(Native Method)
at org.eclipse.swt.widgets.Tree.updateScrollBar(Tree.java:5650)
at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1601)
at org.eclipse.swt.widgets.Scrollable.WM_SIZE(Scrollable.java:348)
at org.eclipse.swt.widgets.Composite.WM_SIZE(Composite.java:1714)
at org.eclipse.swt.widgets.Tree.WM_SIZE(Tree.java:7071)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:4795)
at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method)
at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1546)
at org.eclipse.swt.widgets.Control.WM_WINDOWPOSCHANGED(Control.java:5644)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:4808)
at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method)
at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1546)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:4819)
at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4757)
at org.eclipse.swt.internal.win32.OS.SendMessage(Native Method)
at org.eclipse.swt.widgets.Tree.removeAll(Tree.java:3933)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.refreshBrowser(HopVfsFileDialog.java:761)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.navigateTo(HopVfsFileDialog.java:1068)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.fileDefaultSelected(HopVfsFileDialog.java:692)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3922)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3524)
at org.apache.hop.ui.core.vfs.HopVfsFileDialog.open(HopVfsFileDialog.java:520)
at org.apache.hop.ui.core.dialog.BaseDialog.presentFileDialog(BaseDialog.java:192)
at org.apache.hop.ui.core.dialog.BaseDialog.presentFileDialog(BaseDialog.java:97)
at org.apache.hop.ui.hopgui.delegates.HopGuiFileDelegate.fileOpen(HopGuiFileDelegate.java:66)
at org.apache.hop.ui.hopgui.HopGui.menuFileOpen(HopGui.java:530)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hop.ui.core.gui.BaseGuiWidgets.lambda$getListener$1(BaseGuiWidgets.java:145)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3922)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3524)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:363)
at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:299)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744747028
@usbrandon , confirmed it is now working as expected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744056954
Here is a new version which deactivates the refreshing during the calculation of the 3 columns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] usbrandon commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
usbrandon commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744053357
I tried something else on my computer, a Lenovo P53 with both Intel 630 and Nvidia capabilities. In the BIOS it was set to "Hybrid". When I changed this to discrete, which causes only the Nvidia card to be used, the flicker went away. Hybrid mode must be trying to use the Intel chip for some graphic rendering and Nvidia for other. Somewhere in there I guess there is a conflict that can cause this flickering. -- So I would still give this fix a thumbs up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] usbrandon commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
usbrandon commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744042016
Your latest push fixed the NPE issue and I can browse into folders. There are some strange things that happen though, for example the window opens with a weird default size (too narrow), but the folder name's are perfect. The column headers flicker into the dialog at the top. --- So it functions, but now a flicker and some additional resizing are required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744037175
@usbrandon can you try with this version (calculate column width in UI thread) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva merged pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org