You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/15 05:13:04 UTC
[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5086
Change subject: [MonoTime] use operator '<' instead of ComesBefore
......................................................................
[MonoTime] use operator '<' instead of ComesBefore
For bring better readability and please syntactic sugar addicts, use
operator '<' instead of MonoTime::ComesBefore().
This change does not contain functional changes.
Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
---
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/result_tracker.cc
M src/kudu/tserver/tablet_copy_service.cc
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5086/1
--
To view, visit http://gerrit.cloudera.org:8080/5086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [MonoTime] use operator '<' instead of ComesBefore
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [MonoTime] use operator '<' instead of ComesBefore
......................................................................
[MonoTime] use operator '<' instead of ComesBefore
To bring better readability and please syntactic sugar addicts, use
operator '<' instead of MonoTime::ComesBefore().
This change does not contain functional changes.
Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
---
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/result_tracker.cc
M src/kudu/tserver/tablet_copy_service.cc
5 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5086/2
--
To view, visit http://gerrit.cloudera.org:8080/5086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [MonoTime] use operator '<' instead of ComesBefore
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [MonoTime] use operator '<' instead of ComesBefore
......................................................................
[MonoTime] use operator '<' instead of ComesBefore
To bring better readability and please syntactic sugar addicts, use
operator '<' instead of MonoTime::ComesBefore().
This change does not contain functional changes.
Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Reviewed-on: http://gerrit.cloudera.org:8080/5086
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/result_tracker.cc
M src/kudu/tserver/tablet_copy_service.cc
5 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09f134241825aa19cea95bfa9e678cb3abae8807
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>