[GitHub] [arrow-datafusion] izveigor commented on a diff in pull request #6940: Column support for array_to_string

["izveigor (via GitHub)" <gi...@apache.org>]

izveigor commented on code in PR #6940:
URL: https://github.com/apache/arrow-datafusion/pull/6940#discussion_r1264064741


##########
datafusion/core/tests/sqllogictests/test_files/array.slt:
##########
@@ -344,22 +344,22 @@ select array_prepend(100.1, column2), array_prepend('.', column3) from arrays;
 ## array_fill
 
 # array_fill scalar function #1
-query error DataFusion error: SQL error: ParserError\("Expected an SQL statement, found: caused"\)
-caused by
-Error during planning: Cannot automatically convert List\(Field \{ name: "item", data_type: List\(Field \{ name: "item", data_type: List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\) to List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\)
+query ???
 select array_fill(11, make_array(1, 2, 3)), array_fill(3, make_array(2, 3)), array_fill(2, make_array(2));

Review Comment:
   `array_fill` will not be used in future versions (due to the inability to properly set the data type)
   It will be replaced with `array_repeat`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org