You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/07/24 03:21:52 UTC

[GitHub] [incubator-iotdb] LebronAl opened a new pull request #1555: [IOTDB-815]Support cluster_name check

LebronAl opened a new pull request #1555:
URL: https://github.com/apache/incubator-iotdb/pull/1555


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1555: [IOTDB-815] Support cluster_name check

Posted by GitBox <gi...@apache.org>.
LebronAl commented on a change in pull request #1555:
URL: https://github.com/apache/incubator-iotdb/pull/1555#discussion_r459976931



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,6 +57,10 @@ max_concurrent_client_num=10000
 # number of replications for one partition
 default_replica_num=2
 
+# cluster name to identity different cluster
+# all node's cluster_name in one cluster are same

Review comment:
       embarrassed…fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1555: [IOTDB-815] Support cluster_name check

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on a change in pull request #1555:
URL: https://github.com/apache/incubator-iotdb/pull/1555#discussion_r459925257



##########
File path: cluster/src/assembly/resources/conf/iotdb-cluster.properties
##########
@@ -57,6 +57,10 @@ max_concurrent_client_num=10000
 # number of replications for one partition
 default_replica_num=2
 
+# cluster name to identity different cluster
+# all node's cluster_name in one cluster are same

Review comment:
       identity -> identify
   different cluster -> different clusters
   same -> the same




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] jt2594838 merged pull request #1555: [IOTDB-815] Support cluster_name check

Posted by GitBox <gi...@apache.org>.
jt2594838 merged pull request #1555:
URL: https://github.com/apache/incubator-iotdb/pull/1555


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org