You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2018/10/02 15:09:36 UTC

[Bug 7638] New: File handle Leak in Spamc

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7638

            Bug ID: 7638
           Summary: File handle Leak in Spamc
           Product: Spamassassin
           Version: 3.4.2
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: spamc/spamd
          Assignee: dev@spamassassin.apache.org
          Reporter: kmcgrail@apache.org
  Target Milestone: Undefined

Frm Ondřej Lysoněk <ol...@redhat.com> on the list

This applies both to 3.4 and trunk.

---
 spamc/spamc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/spamc/spamc.c b/spamc/spamc.c
index 38a7df5..8702cfe 100644
--- a/spamc/spamc.c
+++ b/spamc/spamc.c
@@ -616,6 +616,7 @@ combine_args(char *config_file, int argc, char **argv,
                fprintf(stderr,"Exceeded max line size (%d) in %s\n",
                         CONFIG_MAX_LINE_SIZE-2, config_file);
            }
+           fclose(config);
            return EX_CONFIG;
        }

@@ -629,6 +630,7 @@ combine_args(char *config_file, int argc, char **argv,
             if (*combo_argc >= COMBO_ARGV_SIZE) {
                fprintf(stderr,"Exceeded max number of arguments (%d) in %s\n",
                        COMBO_ARGV_SIZE, config_file);
+               fclose(config);
                return EX_CONFIG;
             }
             combo_argv[*combo_argc] = strdup(tok);

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7638] File handle Leak in Spamc

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7638

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |giovanni@paclan.it
         Resolution|---                         |FIXED

--- Comment #1 from Giovanni Bechis <gi...@paclan.it> ---
Fixed in r1842645, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.