You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 00:32:52 UTC

[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

xinyiZzz opened a new pull request, #9870:
URL: https://github.com/apache/incubator-doris/pull/9870

   # Proposed changes
   
   Issue Number: close #9865 #9869
   
   ## Problem Summary:
   
   1. Vectorized join builds the hash table in a separate thread, but does not attach the query mem tracker in TLS when the thread starts, which will result in missing query memory statistics.
   
   2. Minidump FileStat and StorageBackend FileStat have the same name, resulting in an incorrect destructor call.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei merged pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#issuecomment-1141587156

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885175360


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   > Maybe we could remove minidump, it is not too much useful any more.
   
   i agree too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885136671


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   There is already a core stack in be.out, most of us use this core stack.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885124574


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   Maybe we could remove minidump, it is not too much useful any more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#issuecomment-1141587171

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885294449


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   > > Maybe we could remove minidump, it is not too much useful any more.
   > 
   > i agree too
   
   ok, I plan to remove minidump.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#discussion_r885130836


##########
be/src/runtime/minidump.cpp:
##########
@@ -32,11 +32,12 @@ int Minidump::_signo = SIGUSR1;
 std::unique_ptr<google_breakpad::ExceptionHandler> Minidump::_error_handler = nullptr;
 
 // Save the absolute path and create_time of a minidump file
-struct FileStat {
+struct MinidumpFileStat {
     std::string abs_path;

Review Comment:
   I agree,
   Usually online clusters do not enable core dump, not sure if minidump will help



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] xinyiZzz commented on pull request #9870: [bug] Fix BE core about vectorized join build thread memtracker switch, and FileStat duplicate

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #9870:
URL: https://github.com/apache/incubator-doris/pull/9870#issuecomment-1141787970

   > LGTM
   
   p0 failed, not the problem of this pr, 
   
   force push after rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org