[GitHub] [pinot] JeffBolle commented on pull request #11544: Use streamType for parsing and validating protobuf decoder config

["JeffBolle (via GitHub)" <gi...@apache.org>]

JeffBolle commented on PR #11544:
URL: https://github.com/apache/pinot/pull/11544#issuecomment-1712167720

   When calling `streamConfig.getDecoderProperties()`, you get back a map of just the decoder properties that, for the test data, looks like this:
   ```
   {protoClassName=test, descriptorFile=file://test}
   ````
   The checks in `validateDecoder` can be substantially more simple (and not require any stream config knowledge).
   
   I created a PR with my fixes here: https://github.com/apache/pinot/pull/11551
   
   Sorry @navina for putting us down the wrong path with too cursory of a look at the validation code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org