You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2024/05/14 14:12:21 UTC
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21425
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Until now, the float and double data types were not supported in Iceberg
metadata tables. This commit adds support for them.
Testing:
- added a test table that contains all primitive types (except for
decimal, which is still not supported), a struct, an array and a map
- added a test query that queries the `files` metadata table of the
above table - the 'readable_metrics' struct contains lower and upper
bounds for all columns in the original table, with the original type
Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
---
M be/src/exec/iceberg-metadata/iceberg-row-reader.cc
M be/src/exec/iceberg-metadata/iceberg-row-reader.h
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
5 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/21425/1
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thank you, Daniel! I left a minor comment.
http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:
http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql@3916
PS1, Line 3916: INSERT INTO {db_name}{db_suffix}.{table_name} VALUES (
nit: More rows with different values could give better insight into how upper/lower/nan count/value count changes in the newly added test case.
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 07:08:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Until now, the float and double data types were not supported in Iceberg
metadata tables. This commit adds support for them.
Testing:
- added a test table that contains all primitive types (except for
decimal, which is still not supported), a struct, an array and a map
- added a test query that queries the `files` metadata table of the
above table - the 'readable_metrics' struct contains lower and upper
bounds for all columns in the original table, with the original type
Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
---
M be/src/exec/iceberg-metadata/iceberg-row-reader.cc
M be/src/exec/iceberg-metadata/iceberg-row-reader.h
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
5 files changed, 105 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/21425/2
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 15:43:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10641/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 15:43:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 15:41:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:
http://gerrit.cloudera.org:8080/#/c/21425/1/testdata/datasets/functional/functional_schema_template.sql@3916
PS1, Line 3916: INSERT INTO {db_name}{db_suffix}.{table_name} VALUES (
> nit: More rows with different values could give better insight into how upp
You're right, added a new row.
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 12:18:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Until now, the float and double data types were not supported in Iceberg
metadata tables. This commit adds support for them.
Testing:
- added a test table that contains all primitive types (except for
decimal, which is still not supported), a struct, an array and a map
- added a test query that queries the `files` metadata table of the
above table - the 'readable_metrics' struct contains lower and upper
bounds for all columns in the original table, with the original type
Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
---
M be/src/exec/iceberg-metadata/iceberg-row-reader.cc
M be/src/exec/iceberg-metadata/iceberg-row-reader.h
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
5 files changed, 122 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/21425/3
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Until now, the float and double data types were not supported in Iceberg
metadata tables. This commit adds support for them.
Testing:
- added a test table that contains all primitive types (except for
decimal, which is still not supported), a struct, an array and a map
- added a test query that queries the `files` metadata table of the
above table - the 'readable_metrics' struct contains lower and upper
bounds for all columns in the original table, with the original type
Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Reviewed-on: http://gerrit.cloudera.org:8080/21425
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/iceberg-metadata/iceberg-row-reader.cc
M be/src/exec/iceberg-metadata/iceberg-row-reader.h
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
5 files changed, 122 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 )
Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2171c9aa9b6d2b634b8c511263b1610cb1d7cb29
Gerrit-Change-Number: 21425
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2024 20:51:32 +0000
Gerrit-HasComments: No