You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/10/19 02:07:18 UTC

[Bug 123497] New: Color Palette Modify Button - does not save modifications

https://issues.apache.org/ooo/show_bug.cgi?id=123497

            Bug ID: 123497
        Issue Type: DEFECT
           Summary: Color Palette Modify Button - does not save
                    modifications
           Product: General
           Version: 4.0.1
          Hardware: PC
                OS: Windows 8
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: o2b@netzero.net
                CC: issues@openoffice.apache.org

To view defect using Writer:
01)  Open or start new document.
02)  Add shape (square, circle, etc.)
03)  Right-click on shape
04)  Select 'Area...'
05)  Left-click on 'Colors' tab
06)  Left-click any color on grid 
     (i.e. Black - R:000 G:000 B:000)
07)  Change the color using the RGB selectors 
     at the right (i.e. Red - R:255 G:100 B:100)
08)  Left-click the 'Modify' button
     Note that the color on the grid 
     indicates that it has been modified
09)  Left-click the 'OK' button at the bottom
     of the dialog window

ERROR message window appears:
   The color was modified without saving.
   Modify the selected color or add a new color.
      [ Modify ]   [  Add  ]   [ Cancel ]

10)  Left-click the 'Modify' button.
     Note that upon returning to the document,
     the shape color is the unmodified color.

Returning to the Area > Color section shows the color on the grid has not being
modified.

Modifying the name does fine.
When modifying the name and color, only the name is modified.

Going to 'Tools' > 'Options' > 'Colors' without using the shape/area interface
results in the same bug but without the error message.

'Add' does save both a new name and color but the color cannot be modified once
it has been added.

Due to physical limitations, modifying the .soc file is not an option.

Hope this helps.  Screen shots, though not likely needed, are available upon
request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

kellybellis@gwi.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kellybellis@gwi.net

--- Comment #1 from kellybellis@gwi.net ---
Nice report - and I can confirm this in OO v4.0.1, , it's been driving me
crazy! 

Only recourse is to delete / create separately named new color.

In earlier posts, tutorials, wikis, etc., there was shown an open folder and
save icon - where did they go? Having them available makes perfect sense;
removing them doesn't. Please consider returning the options to save and import
palettes.

Particulars on build:
AOO401m5(Build:9714)  -  Rev. 1524958
2013-09-20 11:40:29 (Fr, 20 Sep 2013)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Indeed the bitmap pattern editor exchanges fg/bg colors each time it gets
chnaged (even when saying OK without change, but not when saying cancel).
STrange, looks as if save and init use colors differently (there are only two
anyways, but these get exchanged)...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Regina Henschel <rb...@t-online.de> ---
I have created bug 123564 for the wrong colors in the foreground and background
list.


Modifying works correctly now in r1535772.

BTW: I wonder, why the commit r1535772 was not reflected to this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdu@apache.org

--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
ALG: Herbert may know, setting him on CC...
@Herbert: The commit was not added to this task, you are the magic man for
this...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, found correct problems, checked that these are solved.

@Regina: Maybe we need an own error for the bitmap pattern thingy, better than
to mit with this one, what do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #12 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1535772 into trunk:
i123497 corrected modify implementations for bitmap, lineend and color
svnbz message delay caused by perl problems after Bugzilla 4.4.1 update

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

kellybellis@gwi.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|kellybellis@gwi.net         |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
                 CC|                            |Armin.Le.Grand@me.com
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |
   Target Milestone|---                         |4.1.0

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Somehow the change gets lost, checking...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

liuping <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
                 CC|                            |doneyourself@gmail.com

--- Comment #13 from liuping <do...@gmail.com> ---
verify AOO410m1(Build:9750)  -  Rev. 1570848
Rev.1570848 on windows7 ,pass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |rb.henschel@t-online.de
     Ever confirmed|0                           |1

--- Comment #2 from Regina Henschel <rb...@t-online.de> ---
The error can be seen in the other modules and in
Tools>Options>OpenOffice>Colors as well. Modifying worked in OOo3.4.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
With a little search in my builds I find:
It is OK in r1476029.
It fails in r1481886.

r1481886 is a debug build here and it shows the errors:

Error: libxml2 error
Document is empty
Line: 1
Column: 1 From File
c:/AOO_2013_05_10/trunk/main/unoxml/source/dom/documentbuilder.cxx at Line 303

Error: libxml2 error
Start tag expected, '<' not found
Line: 1
Column: 1 From File
c:/AOO_2013_05_10/trunk/main/unoxml/source/dom/documentbuilder.cxx at Line 303

But I don't know, whether that is related to this issue.

All on Windows 7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked the code and found that this was wrong for Bitmap, Color and
LineEnd. In all cases, the 'modify' functionality did modify all UI stuff, but
not the entry in the corresponding XPropertyList. Interestingly this is done
for gradients and hatches. The whole mechanism with
XPropertyList/XPropertyEntry needs more rework.
Checking if I found the correct errors...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #11 from hdu@apache.org <hd...@apache.org> ---
(In reply to Armin Le Grand from comment #10)
> @Herbert: The commit was not added to this task, you are the magic man for
> this...

The svnbot sees a "<ProtocolError for issues.apache.org/ooo/xmlrpc.cgi: 500
Internal Server Error>", which is probably related to the recent bugzilla
update to 4.4.1...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123497] Color Palette Modify Button - does not save modifications

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123497

--- Comment #4 from Regina Henschel <rb...@t-online.de> ---
Modifications on self-made bitmaps are not stored too. Modifications on
gradients are stored, no error there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.