You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/06 07:52:27 UTC

[GitHub] [hudi] yanghua commented on a change in pull request #2898: [HUDI-1871] Fix hive conf for Flink writer hive meta sync

yanghua commented on a change in pull request #2898:
URL: https://github.com/apache/hudi/pull/2898#discussion_r627167070



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java
##########
@@ -51,11 +51,10 @@ public HiveSyncTool hiveSyncTool() {
     return new HiveSyncTool(this.syncConfig, this.hiveConf, this.fs);
   }
 
-  public static HiveSyncContext create(Configuration conf) {
+  public static HiveSyncContext create(SerializableConfiguration serConf, Configuration conf) {

Review comment:
       IMO, we'd better make these two parameters more readable. The first one is serialized `Configuration` for Hadoop. The second one is the requirement of Flink right? While, from the name, we can not distinguish them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org