You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/08/20 10:13:22 UTC
[GitHub] [incubator-hugegraph] xiaoleizi2016 opened a new pull request, #1948: fix: modify abnormal logs(#1943)
xiaoleizi2016 opened a new pull request, #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948
I have read the CLA Document and I hereby sign the CLA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r960381649
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
> > RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
> > 这个改不改可以看看其他同学意见
>
> 好像可以根据包路径配置日志的
是可以, 当然我指的是运行时动态调整日志级别 (不过那个也可以单独修改)
这里复用一个类名是不是有什么其他历史考量呢, 需要确认一下 @javeme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r950865896
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
这个改不改可以看看其他同学意见
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #1948: refact: modify abnormal logs
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#issuecomment-1223641235
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1948](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcb7bb4) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/7274a5f67d310b6284fd9a8e9da25aae90b616aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7274a5f) will **decrease** coverage by `16.84%`.
> The diff coverage is `80.35%`.
```diff
@@ Coverage Diff @@
## master #1948 +/- ##
=============================================
- Coverage 70.47% 53.63% -16.85%
+ Complexity 724 655 -69
=============================================
Files 452 452
Lines 38984 38990 +6
Branches 5554 5554
=============================================
- Hits 27473 20911 -6562
- Misses 8814 15897 +7083
+ Partials 2697 2182 -515
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvQWNjZXNzQVBJLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvQmVsb25nQVBJLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvR3JvdXBBUEkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvVGFyZ2V0QVBJLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../java/com/baidu/hugegraph/api/job/ComputerAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2pvYi9Db21wdXRlckFQSS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3Byb2ZpbGUvR3JhcGhzQVBJLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...u/hugegraph/api/traversers/CustomizedPathsAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3RyYXZlcnNlcnMvQ3VzdG9taXplZFBhdGhzQVBJLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...om/baidu/hugegraph/api/traversers/VerticesAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3RyYXZlcnNlcnMvVmVydGljZXNBUEkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...om/baidu/hugegraph/api/variables/VariablesAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3ZhcmlhYmxlcy9WYXJpYWJsZXNBUEkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/com/baidu/hugegraph/license/LicenseVerifier.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbGljZW5zZS9MaWNlbnNlVmVyaWZpZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [208 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1948/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] xiaoleizi2016 commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
xiaoleizi2016 commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r952195870
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
> RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
>
> 这个改不改可以看看其他同学意见
好像可以根据包路径配置日志的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r950868819
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/core/GraphManager.java:
##########
@@ -76,7 +76,7 @@
public final class GraphManager {
- private static final Logger LOG = Log.logger(RestServer.class);
+ private static final Logger LOG = Log.logger(GraphManager.class);
Review Comment:
correct it here (✓)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] xiaoleizi2016 commented on pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
xiaoleizi2016 commented on PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#issuecomment-1222438363
> And u'd better to run test in your local env first (make sure CI/Tests are also updated)
>
> <img alt="image" width="1086" src="https://user-images.githubusercontent.com/17706099/185799758-cd01c614-4a73-4551-a344-746b50635c09.png">
solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r960385583
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/API.java:
##########
@@ -45,7 +45,7 @@
public class API {
- protected static final Logger LOG = Log.logger(RestServer.class);
+ protected static final Logger LOG = Log.logger(API.class);
Review Comment:
Also, it would be nice if the log-framework could support a unified approach like this (I don't know if there is a way) :
`Logger LOG = Log.logger(this);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#issuecomment-1221572587
And u'd better to run test in your local env first (make sure CI/Tests are also updated)
<img width="1086" alt="image" src="https://user-images.githubusercontent.com/17706099/185799758-cd01c614-4a73-4551-a344-746b50635c09.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r951108481
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
> 这块我能理解，但是看已有代码也不够统一
嗯嗯后面有些修正是需要的 ✓ (那种一般是更新类名的时候没注意一起调整)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r950865896
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
这个该不该可以看看其他同学意见
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] xiaoleizi2016 commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
xiaoleizi2016 commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r951043635
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/auth/AccessAPI.java:
##########
@@ -59,7 +59,7 @@
@Tag(name = "AccessAPI")
public class AccessAPI extends API {
- private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
这块我能理解，但是看已有代码也不够统一
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1948: fix: modify abnormal logs(#1943)
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1948:
URL: https://github.com/apache/incubator-hugegraph/pull/1948#discussion_r960385583
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/API.java:
##########
@@ -45,7 +45,7 @@
public class API {
- protected static final Logger LOG = Log.logger(RestServer.class);
+ protected static final Logger LOG = Log.logger(API.class);
Review Comment:
Also, it would be nice if the log-framework could support a unified approach like this (I don't know if there is a way) :
`Logger LOG = Log.logger(this);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org