You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Quanlong Huang (Jira)" <ji...@apache.org> on 2023/06/07 00:34:00 UTC

[jira] [Commented] (IMPALA-532) Impala should tolerate bad locale settings.

    [ https://issues.apache.org/jira/browse/IMPALA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729871#comment-17729871 ] 

Quanlong Huang commented on IMPALA-532:
---------------------------------------

We now print the locale at startup:
{code:cpp}
  LOG(INFO) << "Using locale: " << std::locale("").name(); {code}
[https://github.com/apache/impala/blob/4cf0bfa83f9641eb95d83c76af7962e6a3f1e064/be/src/common/init.cc#L497]

We can capture the error there and print the effective locale name with a meaningful exit message. Admins then can check whether the specific locale is missing on the node and install it if missing.

> Impala should tolerate bad locale settings.
> -------------------------------------------
>
>                 Key: IMPALA-532
>                 URL: https://issues.apache.org/jira/browse/IMPALA-532
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 1.1
>            Reporter: Ishaan Joshi
>            Assignee: Pranav Yogi Lodha
>            Priority: Major
>              Labels: newbie, ramp-up, supportability
>
> Currently, the Statestore does not tolerate a bad locale setting and crashes while starting up.
> {code}
>  USE_DEBUG_BUILD=false
> + perl -pi -e 's#{{CMF_CONF_DIR}}#/var/run/cloudera-scm-agent/process/2469-impala-STATESTORE#g' /var/run/cloudera-scm-agent/process/2469-impala-STATESTORE/impala-conf/state_store_flags
> perl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
>     LANGUAGE = (unset),
>     LC_ALL = (unset),
>     LANG = "fr_FR.UTF-8"
>     are supported and installed on your system.
> perl: warning: Falling back to the standard locale ("C").
> + '[' -f /var/run/cloudera-scm-agent/process/2469-impala-STATESTORE/impala-conf/.htpasswd ']'
> + chmod 600 /var/run/cloudera-scm-agent/process/2469-impala-STATESTORE/impala-conf/.htpasswd
> + false
> + export IMPALA_BIN=/opt/cloudera/parcels/IMPALA-1.1-1.p0.8/lib/impala/sbin-retail
> + IMPALA_BIN=/opt/cloudera/parcels/IMPALA-1.1-1.p0.8/lib/impala/sbin-retail
> + '[' impalad = statestore ']'
> + '[' statestore = statestore ']'
> + exec /opt/cloudera/parcels/IMPALA-1.1-1.p0.8/lib/impala/../../bin/statestored --flagfile=/var/run/cloudera-scm-agent/process/2469-impala-STATESTORE/impala-conf/state_store_flags
> terminate called after throwing an instance of 'std::runtime_error'
>   what():  locale::facet::_S_create_c_locale name not valid
> {code}
> It should fall back to the standard locale ("C"), if the user's locale is messed up.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org