You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by omalley <gi...@git.apache.org> on 2016/01/08 20:22:20 UTC
[GitHub] orc pull request: ORC-36. Create a test program that writes ORC fi...
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/14
ORC-36. Create a test program that writes ORC files from future versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-36
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 56c2db2ce1b7fb59621a8ef04cd10e846ba72338
Author: Aliaksei Sandryhaila <al...@hp.com>
Date: 2016-01-08T17:37:25Z
A minor bug fix for ORC-29: Ensure successful compilation when C++11 is not supported.
commit 6071e6dd5f5cf769d17b4d3517fce3e881da080e
Author: Owen O'Malley <om...@apache.org>
Date: 2016-01-08T19:20:41Z
ORC-36. Create a test program that writes ORC files from future versions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request: ORC-36. Create a test program that writes ORC fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request: ORC-36. Create a test program that writes ORC fi...
Posted by asandryh <gi...@git.apache.org>.
Github user asandryh commented on the pull request:
https://github.com/apache/orc/pull/14#issuecomment-170107861
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request: ORC-36. Create a test program that writes ORC fi...
Posted by asandryh <gi...@git.apache.org>.
Github user asandryh commented on a diff in the pull request:
https://github.com/apache/orc/pull/14#discussion_r49231081
--- Diff: c++/src/TypeImpl.cc ---
@@ -416,7 +416,7 @@ namespace orc {
std::unique_ptr<Type> buildSelectedType(const Type *fileType,
const std::vector<bool>& selected) {
if (fileType == nullptr || !selected[fileType->getColumnId()]) {
- return nullptr;
+ return std::unique_ptr<Type>();
}
--- End diff --
I have already pulled in this fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---