You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by "SbloodyS (via GitHub)" <gi...@apache.org> on 2023/04/19 06:52:10 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #13866: [Feature][plugin] Add databend datasource in datasource plugin

SbloodyS commented on code in PR #13866:
URL: https://github.com/apache/dolphinscheduler/pull/13866#discussion_r1170881595


##########
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/DbType.java:
##########
@@ -46,7 +46,8 @@ public enum DbType {
     DAMENG(15, "dameng"),
     OCEANBASE(16, "oceanbase"),
     SSH(17, "ssh"),
-    KYUUBI(18, "kyuubi");
+    DATABEND(18, "databend"),
+    KYUUBI(19, "kyuubi");

Review Comment:
   Since we've merged kyuubi's PR in #13642. It's better not to change its order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org