You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2013/01/04 12:07:13 UTC

svn commit: r1428787 - in /qpid/trunk/qpid/java/jca: ./ rar/ rar/src/ rar/src/main/ rar/src/main/resources/ rar/src/main/resources/META-INF/ src/main/resources/META-INF/

Author: robbie
Date: Fri Jan  4 11:07:12 2013
New Revision: 1428787

URL: http://svn.apache.org/viewvc?rev=1428787&view=rev
Log:
QPID-4527: update the JCA module to use the standard build target implementation, rather than replacing it.

- Overrides the output destinations (to give the filenames 'ra' instead of 'jca' as it was doing) and uses the postbuild target to additionally create the rar and examples.
- Moves the META-INF resources for the rar file to their own directory, removing need to specifically prevent their inclusion in the jar file.

Added:
    qpid/trunk/qpid/java/jca/rar/
    qpid/trunk/qpid/java/jca/rar/src/
    qpid/trunk/qpid/java/jca/rar/src/main/
    qpid/trunk/qpid/java/jca/rar/src/main/resources/
    qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/
    qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/jboss-ra.xml
      - copied, changed from r1428785, qpid/trunk/qpid/java/jca/src/main/resources/META-INF/jboss-ra.xml
    qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml
      - copied, changed from r1428785, qpid/trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml
Removed:
    qpid/trunk/qpid/java/jca/src/main/resources/META-INF/jboss-ra.xml
    qpid/trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml
Modified:
    qpid/trunk/qpid/java/jca/build.xml

Modified: qpid/trunk/qpid/java/jca/build.xml
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/jca/build.xml?rev=1428787&r1=1428786&r2=1428787&view=diff
==============================================================================
--- qpid/trunk/qpid/java/jca/build.xml (original)
+++ qpid/trunk/qpid/java/jca/build.xml Fri Jan  4 11:07:12 2013
@@ -25,26 +25,23 @@
   <!-- Hack to make the renamed module jars available on the module test classpath -->
   <property name="module.test.depends" value="ra ra/tests"/>
 
-  <import file="../module.xml"/>
-
-  <property name="module.rar" value="${build.lib}/${project.name}-ra-${project.version}.rar"/>
-
-  <property name="module.resources" value="src/main/resources"/>
+  <!-- Import common.xml to make the properties it defines available before importing module.xml -->
+  <import file="../common.xml"/>
 
-  <target name="rar" depends="jar.nomanifest">
+  <!-- Override the standard output jar names before importing module.xml, to produce
+       artifacts that use ra in the name instead of jca like the module should -->
+  <property name="module.test.jar" value="${build.lib}/${project.name}-ra-tests-${project.version}.jar"/>
+  <property name="module.jar" value="${build.lib}/${project.name}-ra-${project.version}.jar"/>
+  <property name="module.source.jar" value="${build.lib}/${project.name}-ra-${project.version}-sources.jar"/>
 
-      <!--Note we need to do this as we need to keep the ra in the name of the artificats but we can't override the module.jar property which is based on the directory name. Also, we re-jar to avoid duplicate *.xml files in the jar and the rar which is causing EAP deployment issues in later versions.-->
-    <delete file="${build.lib}/${project.name}-${module.name}-${project.version}.jar"/>
+  <import file="../module.xml"/>
 
-    <jar destfile="${module.jar}" basedir="${module.classes}">
-       <metainf dir="${module.metainf}" >
-	  <exclude name="**/*.xml"/>
-       </metainf>
-    </jar>
-    <move file="${build.lib}/${project.name}-${module.name}-${project.version}.jar" tofile="${build.lib}/${project.name}-ra-${project.version}.jar"/>
+  <property name="module.rar" value="${build.lib}/${project.name}-ra-${project.version}.rar"/>
+  <property name="rar.resources" value="rar/src/main/resources"/>
 
+  <target name="rar" depends="jar" description="creates a rar file containing the module jar, client jars, etc">
     <jar destfile="${module.rar}">
-      <fileset dir="${module.resources}">
+      <fileset dir="${rar.resources}">
         <include name="**/*.xml"/>
       </fileset>
       <fileset dir="${build.lib}">
@@ -78,11 +75,9 @@
 
   <target name="examples" depends="example-properties-file, example-jars"/>
 
-  <target name="build" depends="rar, examples, jar-tests, jar-sources, postbuild"/>
+  <target name="postbuild" depends="rar, examples"/>
 
-  <target name="postbuild">
-     <!-- Hack to make the tests/sources jar names match the renamed main module jar/rar -->
-     <move file="${module.test.jar}" tofile="${build.lib}/${project.name}-ra-tests-${project.version}.jar"/>
-     <move file="${module.source.jar}" tofile="${build.lib}/${project.name}-ra-${project.version}-sources.jar"/>
-  </target>
+  <!-- Override module.xml 'libs' target to avoid copying the jar files dependencies
+       into the 'build/lib' dir, since they will be supplied by the app server -->
+  <target name="libs"/>
 </project>

Copied: qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/jboss-ra.xml (from r1428785, qpid/trunk/qpid/java/jca/src/main/resources/META-INF/jboss-ra.xml)
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/jboss-ra.xml?p2=qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/jboss-ra.xml&p1=qpid/trunk/qpid/java/jca/src/main/resources/META-INF/jboss-ra.xml&r1=1428785&r2=1428787&rev=1428787&view=diff
==============================================================================
    (empty)

Copied: qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml (from r1428785, qpid/trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml)
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml?p2=qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml&p1=qpid/trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml&r1=1428785&r2=1428787&rev=1428787&view=diff
==============================================================================
    (empty)



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org