You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/03/22 11:27:08 UTC

[GitHub] [incubator-paimon] FangYongs opened a new pull request, #691: [core] Use enum instead of string for file.format

FangYongs opened a new pull request, #691:
URL: https://github.com/apache/incubator-paimon/pull/691

   ### Purpose
   
   Use enum instead of string for file.format and validate the format value in ddl
   
   ### Tests
   
   1. Added the test `SchemaManagerTest.testInvalidFormatType` to validate the format value
   
   ### API and Format 
   
   *(Does this change affect API or storage format)* no
   
   ### Documentation
   
   *(Does this change introduce a new feature)* no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi merged pull request #691: [core] Use enum instead of string for file.format

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #691:
URL: https://github.com/apache/incubator-paimon/pull/691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] FangYongs commented on pull request #691: [core] Use enum instead of string for file.format

Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #691:
URL: https://github.com/apache/incubator-paimon/pull/691#issuecomment-1480438784

   Thanks @JingsongLi  Updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #691: [core] Use enum instead of string for file.format

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #691:
URL: https://github.com/apache/incubator-paimon/pull/691#discussion_r1144661797


##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -956,6 +962,31 @@ public InlineElement getDescription() {
         }
     }
 
+    /** Specifies the file format type for store. */
+    public enum FileFormatType implements DescribedEnum {
+        ORC("orc", "ORC format for file store."),

Review Comment:
   maybe remove `file store`? now log store is only in flink



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #691: [core] Use enum instead of string for file.format

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #691:
URL: https://github.com/apache/incubator-paimon/pull/691#discussion_r1144662558


##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -100,6 +101,9 @@ public static void validateTableSchema(TableSchema schema) {
             }
         }
 
+        // Valid the format type
+        checkNotNull(options.formatType());

Review Comment:
   option with default value should never return null.
   we don't need this checking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org