You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2016/09/12 10:05:38 UTC
[GitHub] tinkerpop pull request #404: TINKERPOP-1280 VertexPrograms should declare tr...
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/404
TINKERPOP-1280 VertexPrograms should declare traverser requirements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #404
----
commit b3258693f8af76ec73fd76154523d45f606f2bfa
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2016-09-12T08:43:39Z
Allow VertexPrograms to declare their traverser requirements.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #404: TINKERPOP-1280 VertexPrograms should declare traverser...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/404
Very well done code. In other words, in full arrogance and conceit, this is exactly how I would have done it thus, you work is perfect.
And like me, I would have skimped on the JavaDoc. Can you please add JavaDoc to `VertexProperty.getTraverserRequirements()` before merging to master.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #404: TINKERPOP-1280 VertexPrograms should declare traverser...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/404
Most excellent and good tests.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #404: TINKERPOP-1280 VertexPrograms should declare tr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #404: TINKERPOP-1280 VertexPrograms should declare traverser...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/404
You mean `VertexProgram.getTraverserRequirements()`? [It already has its JavaDoc](https://github.com/apache/tinkerpop/pull/404/files#diff-ca108f45ec7b5a288dfce8019f1a6813R188).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---