You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/03/28 21:57:43 UTC

[GitHub] [incubator-devlake] keon94 opened a new issue, #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

keon94 opened a new issue, #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805

   ## What and why to refactor
   The prod Dockerfile (devlake) and CI Dockerfile (lake-builder) share a lot of dependencies, and are built on top of a Go (Alpine) and Python (Debian) base image. 
   
   ## Describe the solution you'd like
   1. Create two Dockerfiles for each of the base images mentioned above to install the common dependencies into each of them. The Prod and CI Dockerfiles should then inherit from these images instead.
   2. Move the Prod Dockerfile to the devops directory to be consistent with the other Dockerfiles, and create a Github workflow to trigger pushing it to Dockerfile and support the "latest" tag. I suggest "latest" to be reserved for only main-builds, and versioned images based on pushed tags similar to CI. Update Readme accordingly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1497899131

   @klesh Should we use a custom tag then? Like `dev`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1491448314

   @keon94 we should update the `latest` tag only for `formal` releases, e.g. v0.16.1/0.17.0 those without suffixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1675557452

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1499891219

   @klesh I was thinking after every merge to main we run the job on the main branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1685137602

   This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1539221764

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1499862610

   > @klesh Should we use a custom tag then? Like `dev`?
   
   When will we update the `dev` tag?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] closed issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds
URL: https://github.com/apache/incubator-devlake/issues/4805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1499908008

   @keon94 I see, who would be using this `dev` for what purposes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1583659515

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4805: [Refactor][Build] Unify common parts of CI and Prod Dockerfile into base images and automate Prod image builds

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4805:
URL: https://github.com/apache/incubator-devlake/issues/4805#issuecomment-1629909573

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org