You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2021/10/27 19:19:48 UTC

[GitHub] [incubator-hop] mattcasters commented on a change in pull request #1176: HOP-3454

mattcasters commented on a change in pull request #1176:
URL: https://github.com/apache/incubator-hop/pull/1176#discussion_r737774281



##########
File path: plugins/transforms/groupby/src/main/java/org/apache/hop/pipeline/transforms/groupby/GroupBy.java
##########
@@ -69,6 +69,14 @@ public boolean processRow() throws HopException {
     Object[] r = getRow(); // get row!
 
     if (first) {
+
+      // do we have any row at start processing?
+      if (r == null) {

Review comment:
       Please take flag `meta.isAlwaysGivingBackOneRow()` into account.  Perhaps put if (!meta.isAlwaysGivingBackOneRow()) {} around the extra code.
   I think I would also feel better about changing this very popular transform if we had a few integration tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org