You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/16 11:38:26 UTC
[GitHub] [flink] mghildiy opened a new pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
mghildiy opened a new pull request #12189:
URL: https://github.com/apache/flink/pull/12189
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
Objective of this PR is to remove the following deprecated method and update related code:
- RuntimeContext.getFoldingState(...)
- OperatorStateStore.getSerializableListState(...)
- OperatorStateStore.getOperatorState(...)
## Brief change log
NA
## Verifying this change
NA
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / no / **don't know**)
- The runtime per-record code paths (performance sensitive): (yes / no / **don't know**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / **don't know**)
- The S3 file system connector: (yes / no / **don't know**)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 256cc76fe3de06691a8e895633e4a958aebaea4d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635858118
@klion26 I pushed some more changes. Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
}, {
"hash" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2561",
"triggerID" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12189:
URL: https://github.com/apache/flink/pull/12189#discussion_r426572441
##########
File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
##########
@@ -388,7 +389,7 @@ public void initializeState(FunctionInitializationContext context) throws Except
}
OperatorStateStore stateStore = context.getOperatorStateStore();
- restoredBucketStates = stateStore.getSerializableListState("bucket-states");
+ this.restoredBucketStates = stateStore.getListState(new ListStateDescriptor("bucket-states", State.class));
Review comment:
This will not actually work because `getListState(..., State.class)` should be created a `GenericTypeInfo`, which is incompatible with the `JavaSerializer` used before internally here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ec41f21bd41a1ad6e3530acdd92d5f14d264236 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-637466858
pushed changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-645407154
That's a very good point! I'm adding a release note.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-630133483
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
}, {
"hash" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ec41f21bd41a1ad6e3530acdd92d5f14d264236 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434)
* a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612a2656787c525d787f34f211035fa9318f5687 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375)
* 6ec41f21bd41a1ad6e3530acdd92d5f14d264236 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629632638
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 256cc76fe3de06691a8e895633e4a958aebaea4d (Sat May 16 11:41:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
}, {
"hash" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2561",
"triggerID" : "a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ec41f21bd41a1ad6e3530acdd92d5f14d264236 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2434)
* a3afaaf29b9966ae3d0af63b8b6fcdb11ee7342c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 256cc76fe3de06691a8e895633e4a958aebaea4d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
}, {
"hash" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ec41f21bd41a1ad6e3530acdd92d5f14d264236",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612a2656787c525d787f34f211035fa9318f5687 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375)
* 6ec41f21bd41a1ad6e3530acdd92d5f14d264236 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mghildiy commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
mghildiy commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-631839252
Sorry for delay. I am stuck with some issues, and plan to work on it this weekend. If its needed urgently, I am fine with someone else taking it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635415765
@aljoscha Will check it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-645312059
It is probably worthwhile mentioning the transitive effect of these changes in the release notes.
For example, user jars that include the `flink-connector-kafka` dependency based on 1.10 will not work anymore due to the removal of `OperatorStateStore.getSerializableListState`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
klion26 edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635879347
@aljoscha thanks for the update. Remove `FoldingState` and the internals in the state backend later make senses to me. current PR LGTM % `FoldingState` in section `Using Keyed State` `state.md` & `state.zh.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12189:
URL: https://github.com/apache/flink/pull/12189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-631543033
Hey @mghildiy do you still want to work on this issue? This issue actually blocks the 1.11 release. I see you haven't addressed @aljoscha's comment yet. It's fine, but if you don't have time, maybe somebody else could take over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635879347
@aljoscha thanks for the update. Remove `FoldingState` and the internals in the state backend later make senses to me. current PR LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12189:
URL: https://github.com/apache/flink/pull/12189#discussion_r428476861
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java
##########
@@ -219,31 +219,6 @@ public void dispose() {
return getListState(stateDescriptor, OperatorStateHandle.Mode.UNION);
}
- // -------------------------------------------------------------------------------------------
- // Deprecated state access methods
- // -------------------------------------------------------------------------------------------
-
- /**
- * @deprecated This was deprecated as part of a refinement to the function names.
- * Please use {@link #getListState(ListStateDescriptor)} instead.
- */
- @Deprecated
- @Override
- public <S> ListState<S> getOperatorState(ListStateDescriptor<S> stateDescriptor) throws Exception {
- return getListState(stateDescriptor);
- }
-
- /**
- * @deprecated Using Java serialization for persisting state is not encouraged.
- * Please use {@link #getListState(ListStateDescriptor)} instead.
- */
- @SuppressWarnings("unchecked")
- @Deprecated
- @Override
- public <T extends Serializable> ListState<T> getSerializableListState(String stateName) throws Exception {
Review comment:
Maybe we can add an auxiliary function in which the function implementation is same as this function so that we can migrate easily?
The `getSerializableListState()` will always use `deprecatedDefaultJavaSerializer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635801099
@klion26 That's a good point. This PR/Jira issue is about removing the access methods, we can remove `FoldingState` and the internals in the state backend later.
Good point about updating the docs! I will do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 612a2656787c525d787f34f211035fa9318f5687 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 256cc76fe3de06691a8e895633e4a958aebaea4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541)
* 612a2656787c525d787f34f211035fa9318f5687 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2375)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
klion26 edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-635879347
@aljoscha thanks for the update. Remove `FoldingState` and the internals in the state backend later make senses to me. current PR LGTM % `FoldingState` in section `Using Keyed State` `state.md` & `state.zh.md`
diff for `state.zh.md` based on current pr
[state.zh.md.diff.txt](https://github.com/apache/flink/files/4701474/state.zh.md.diff.txt)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-638184617
I've merged this on master and will also merge on release-1.11.
Thanks @mghildiy for the initial work, and thanks @klion26 for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
}, {
"hash" : "612a2656787c525d787f34f211035fa9318f5687",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "612a2656787c525d787f34f211035fa9318f5687",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 256cc76fe3de06691a8e895633e4a958aebaea4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541)
* 612a2656787c525d787f34f211035fa9318f5687 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12189: [FLINK-17376][API/DataStream]Deprecated methods and related code updated
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12189:
URL: https://github.com/apache/flink/pull/12189#issuecomment-629635252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541",
"triggerID" : "256cc76fe3de06691a8e895633e4a958aebaea4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 256cc76fe3de06691a8e895633e4a958aebaea4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1541)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org