Re: [PR] [FLINK-39741][python] Add type hints and fix docstrings in datastream/functions.py [flink]

["Vaibhav-S-Gowda (via GitHub)" <gi...@apache.org>]

Vaibhav-S-Gowda commented on code in PR #28216:
URL: https://github.com/apache/flink/pull/28216#discussion_r3292153853


##########
flink-python/pyflink/datastream/functions.py:
##########
@@ -19,7 +19,7 @@
 from enum import Enum
 
 from py4j.java_gateway import JavaObject
-from typing import Union, Any, Generic, TypeVar, Iterable, List, Callable, Optional
+from typing import Union, Any, Generic, TypeVar, Iterable, Iterator, List, Callable, Optional

Review Comment:
   Hi @davidradl, I have added tests that implement the generic types 
   as you suggested. All 4 tests pass successfully:
   - test_map_function_generics
   - test_flat_map_function_generics  
   - test_filter_function_generics
   - test_key_selector_generics
   
   Updated PR title with JIRA ticket FLINK-39741. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org