Re: Make ResourceResolver implement Closeable

[Robert Munteanu <ro...@lmn.ro>]

On Fri, May 29, 2015 at 1:29 PM, Roy Teeuwen <ro...@teeuwen.be> wrote:
> To come back to my initial question. The closeable interface has been there from Java 1.5, so adding it would do no harm to older versions and would still make it work in Java 1.7+

Good point, filed SLING-4798 [1]

Robert


[1]: https://issues.apache.org/jira/browse/SLING-4798

>
> Greets
> Roy
>> On 26 May 2015, at 16:38, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>> Am 26.05.15 um 16:14 schrieb Robert Munteanu:
>>> Hi Roy,
>>>
>>> On Tue, 2015-05-26 at 15:51 +0200, Roy Teeuwen wrote:
>>>> Hello,
>>>>
>>>> As of Java 7, it is possible by implementing the Closeable or
>>>> AutoCloseable to use the try-with-resources statement. This makes the
>>>> notation a lot shorter than the try-finally block. Is there a reason
>>>> that the ResourceResolver does not implement the Closeable interface,
>>>> and would it be possible to let it implement it?
>>>
>>> We should "just" move to Java 7 by default.
>>>
>> +1
>>
>> Carsten
>>
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org
>



-- 
Sent from my (old) computer