[GitHub] [hbase] HorizonNet commented on a change in pull request #2448: HBASE-25088 CatalogFamilyFormat/MetaTableAccessor.parseRegionInfoFrom…

[GitBox <gi...@apache.org>]

HorizonNet commented on a change in pull request #2448:
URL: https://github.com/apache/hbase/pull/2448#discussion_r494626406



##########
File path: hbase-client/src/test/java/org/apache/hadoop/hbase/TestCatalogFamilyFormat.java
##########
@@ -70,4 +79,32 @@ public void testMetaReaderGetColumnMethods() {
         HConstants.SEQNUM_QUALIFIER_STR + CatalogFamilyFormat.META_REPLICA_ID_DELIMITER + "002A"),
       CatalogFamilyFormat.getSeqNumColumn(42));
   }
+
+  /**
+   * The info we can get from the regionName is: table name, start key, regionId, replicaId.
+   */
+  @Test
+  public void testparseRegionInfoFromRegionName() throws IOException  {
+    TableName tableName = TableName.valueOf(name.getMethodName());
+    long regionId = 999999L;

Review comment:
       NIT: As these variables are only used in the builder (and with that their purpose is also visible) below they can be directly used in the builder.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org