You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2023/06/25 16:45:07 UTC

[spark] branch master updated: [SPARK-43969][SQL][TESTS][FOLLOWUP] Update `numeric.sql.out.java21`

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 0ab6a0e17b2 [SPARK-43969][SQL][TESTS][FOLLOWUP] Update `numeric.sql.out.java21`
0ab6a0e17b2 is described below

commit 0ab6a0e17b27252cd2d9990f6126049b67a2adec
Author: yangjie01 <ya...@baidu.com>
AuthorDate: Sun Jun 25 09:44:57 2023 -0700

    [SPARK-43969][SQL][TESTS][FOLLOWUP] Update `numeric.sql.out.java21`
    
    ### What changes were proposed in this pull request?
    https://github.com/apache/spark/pull/41458 updated `numeric.sql.out` but not update `numeric.sql.out.java21`, this pr updated `numeric.sql.out.java21` for Java 21.
    
    ### Why are the changes needed?
    Fix golden file for Java 21.
    
    https://github.com/apache/spark/actions/runs/5362442727/jobs/9729315685
    
    ```
    [info] - postgreSQL/numeric.sql *** FAILED *** (1 minute, 4 seconds)
    [info]   postgreSQL/numeric.sql
    [info]   Expected "...OLUMN_ARITY_MISMATCH[",
    [info]     "sqlState" : "21S01",
    [info]     "messageParameters" : {
    [info]       "dataColumns" : "'id', 'id', 'val', 'val', '(val * val)'",
    [info]       "reason" : "too many data columns",
    [info]       "tableColumns" : "'id1', 'id2', 'result']",
    [info]       "tableName" :...", but got "...OLUMN_ARITY_MISMATCH[.TOO_MANY_DATA_COLUMNS",
    [info]     "sqlState" : "21S01",
    [info]     "messageParameters" : {
    [info]       "dataColumns" : "`id`, `id`, `val`, `val`, `(val * val)`",
    [info]       "tableColumns" : "`id1`, `id2`, `result`]",
    [info]       "tableName" :..." Result did not match for query #474
    [info]   INSERT INTO num_result SELECT t1.id, t2.id, t1.val, t2.val, t1.val * t2.val
    [info]       FROM num_data t1, num_data t2 (SQLQueryTestSuite.scala:848)
    [info]   org.scalatest.exceptions.TestFailedException:
    [info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
    [info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
    [info]   at org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1564)
    [info]   at org.scalatest.Assertions.assertResult(Assertions.scala:847)
    [info]   at org.scalatest.Assertions.assertResult$(Assertions.scala:842)
    [info]   at org.scalatest.funsuite.AnyFunSuite.assertResult(AnyFunSuite.scala:1564)
    [info]   at org.apache.spark.sql.SQLQueryTestSuite.$anonfun$readGoldenFileAndCompareResults$3(SQLQueryTestSuite.scala:848)
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    - Pass GitHub Actions
    - Manual checked using Java 21
    
    Closes #41720 from LuciferYang/SPARK-43969-FOLLOWUP-2.
    
    Authored-by: yangjie01 <ya...@baidu.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .../resources/sql-tests/results/postgreSQL/numeric.sql.out.java21  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out.java21 b/sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out.java21
index 6a26485c04d..a1d9dbbc830 100644
--- a/sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out.java21
+++ b/sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out.java21
@@ -3832,12 +3832,11 @@ struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
 {
-  "errorClass" : "INSERT_COLUMN_ARITY_MISMATCH",
+  "errorClass" : "INSERT_COLUMN_ARITY_MISMATCH.TOO_MANY_DATA_COLUMNS",
   "sqlState" : "21S01",
   "messageParameters" : {
-    "dataColumns" : "'id', 'id', 'val', 'val', '(val * val)'",
-    "reason" : "too many data columns",
-    "tableColumns" : "'id1', 'id2', 'result'",
+    "dataColumns" : "`id`, `id`, `val`, `val`, `(val * val)`",
+    "tableColumns" : "`id1`, `id2`, `result`",
     "tableName" : "`spark_catalog`.`default`.`num_result`"
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org