You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/22 09:51:51 UTC
[GitHub] [shardingsphere] menghaoranss opened a new issue #6163: Optimize proxy instance definition in registry center
menghaoranss opened a new issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163
According to the suggestions made by @dongzl and @kimmking in the issue #5627 , use `ip+port` instead of `ip + threadId` to define proxy instance in registry center is better.
```
/
├─orchestration-namespace
├─orchestration-name
│ ├─registry
│ │ ├─instances
│ │ │ ├─127.0.0.1@3307@xxx
│ │ │ ├─127.0.0.1@3308@xxx
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-655949261
@swayamraina The pr #6187 you submitted has lasted too long, there may already be a lot of conflicts, can you please resubmit another pr based on our discussion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] swayamraina commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-655952943
sure @menghaoranss will sync the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-650551165
@swayamraina Expecting your forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-656458810
> sure @menghaoranss will sync the PR
merged! thansk for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] swayamraina commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-648641585
Hi!
I believe `OrchestrationInstance` holds this data of `ip + thread-id` which needs to be changed.
I am not sure how to get the port on which the instance is running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] swayamraina commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-656627624
Thanks, will try to contribute more :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss closed issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss closed issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] swayamraina commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-651852394
Will update the code as per review. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-650477279
> @menghaoranss can you please review yhe PR for any improvements.
Of course, i will take the time to review, thanks for you contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-651068786
@swayamraina any problems?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] swayamraina commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
swayamraina commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-650475405
@menghaoranss can you please review yhe PR for any improvements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #6163: Optimize proxy instance definition in registry center
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #6163:
URL: https://github.com/apache/shardingsphere/issues/6163#issuecomment-648654465
@swayamraina For proxy，the port can be passed to `ShardingOrchestrationFacade` when proxy starts, and for jdbc, thread id is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org