You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/11/13 02:17:37 UTC
Review Request 63747: KYLIN-3034 In the models tree,
the "Edit(JSON)" option is missing partly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63747/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3034
https://issues.apache.org/jira/browse/KYLIN-3034
Repository: kylin
Description
-------
1. Open the Model page;
2. Choose one model in model table, and click the "Action" button on right side, then you can find the "Edit(JSON)" option is missing partly not only in full screen, but also in non-full screen;
3. You can also find a scrollbar at the bottom, but you cannot click on it, because when you move away from the "Action", the scrollbar disappears.
So we can modify models_tree.html, add the margin-right setting for "Action" div, which can give more space to options.
Diffs
-----
webapp/app/partials/models/models_tree.html 399f839
Diff: https://reviews.apache.org/r/63747/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 63747: KYLIN-3034 In the models tree,
the "Edit(JSON)" option is missing partly.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63747/
-----------------------------------------------------------
(Updated 十一月 17, 2017, 11:51 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
update the patch for your suggestion, pls check, thanks.
Bugs: KYLIN-3034
https://issues.apache.org/jira/browse/KYLIN-3034
Repository: kylin
Description
-------
1. Open the Model page;
2. Choose one model in model table, and click the "Action" button on right side, then you can find the "Edit(JSON)" option is missing partly not only in full screen, but also in non-full screen;
3. You can also find a scrollbar at the bottom, but you cannot click on it, because when you move away from the "Action", the scrollbar disappears.
So we can modify models_tree.html, add the margin-right setting for "Action" div, which can give more space to options.
Diffs (updated)
-----
webapp/app/partials/models/models_tree.html 399f839
Diff: https://reviews.apache.org/r/63747/diff/3/
Changes: https://reviews.apache.org/r/63747/diff/2-3/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 63747: KYLIN-3034 In the models tree,
the "Edit(JSON)" option is missing partly.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63747/
-----------------------------------------------------------
(Updated 十一月 17, 2017, 8:37 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
modify the patch for: 1. show the options list fully; 2. support for displaying of the new longer option
Bugs: KYLIN-3034
https://issues.apache.org/jira/browse/KYLIN-3034
Repository: kylin
Description
-------
1. Open the Model page;
2. Choose one model in model table, and click the "Action" button on right side, then you can find the "Edit(JSON)" option is missing partly not only in full screen, but also in non-full screen;
3. You can also find a scrollbar at the bottom, but you cannot click on it, because when you move away from the "Action", the scrollbar disappears.
So we can modify models_tree.html, add the margin-right setting for "Action" div, which can give more space to options.
Diffs (updated)
-----
webapp/app/partials/models/models_tree.html 399f839
Diff: https://reviews.apache.org/r/63747/diff/2/
Changes: https://reviews.apache.org/r/63747/diff/1-2/
Testing
-------
Thanks,
pengjianhua