[jira] [Work logged] (BEAM-14181) BQ: Storage API Sink reuses closed connections

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14181?focusedWorklogId=748054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748054 ]

ASF GitHub Bot logged work on BEAM-14181:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/22 22:29
            Start Date: 25/Mar/22 22:29
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #17187:
URL: https://github.com/apache/beam/pull/17187#discussion_r835649623



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
##########
@@ -173,6 +173,12 @@ public DestinationState(
         this.useDefaultStream = useDefaultStream;
       }
 
+      void teardown() {
+        if (streamAppendClient != null) {
+          runAsyncIgnoreFailure(closeWriterExecutor, streamAppendClient::unpin);

Review comment:
       do we need to invalidate it from the cache as well here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 748054)
    Remaining Estimate: 0h
            Time Spent: 10m

> BQ: Storage API Sink reuses closed connections
> ----------------------------------------------
>
>                 Key: BEAM-14181
>                 URL: https://issues.apache.org/jira/browse/BEAM-14181
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Ahmet Altay
>            Assignee: Reuven Lax
>            Priority: P0
>             Fix For: 2.38.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Creating a jira so that it can be considered whether it is release blocking or not.
> Related change: https://github.com/apache/beam/pull/17187



--
This message was sent by Atlassian Jira
(v8.20.1#820001)