You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/14 02:32:32 UTC

[GitHub] [shardingsphere] zhaojinchao95 commented on a diff in pull request #20770: Support using disabled data source at startup(#20738)

zhaojinchao95 commented on code in PR #20770:
URL: https://github.com/apache/shardingsphere/pull/20770#discussion_r970250127


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/metadata/jdbc/JDBCInstanceMetaData.java:
##########
@@ -32,9 +32,18 @@ public final class JDBCInstanceMetaData implements InstanceMetaData {
     
     private final String ip;
     
+    private final boolean force;

Review Comment:
   I think the `force` parameter move to props is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org