You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "ArmandoZ (via GitHub)" <gi...@apache.org> on 2024/02/15 17:16:57 UTC

[PR] ci: Add hdfs test case for s3(#4168) [opendal]

ArmandoZ opened a new pull request, #4184:
URL: https://github.com/apache/opendal/pull/4184

   WIP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3 [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4184:
URL: https://github.com/apache/opendal/pull/4184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3(#4168) [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491883409


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: hdfs_default_s3

Review Comment:
   Good idea. It still possible for us to add `aws_s3` once needed in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3(#4168) [opendal]

Posted by "ArmandoZ (via GitHub)" <gi...@apache.org>.
ArmandoZ commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491386381


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: hdfs_default_s3

Review Comment:
   should we rename occurrences of `s3` to `minio_s3` for clarity?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3 [opendal]

Posted by "armando-zhu-sh (via GitHub)" <gi...@apache.org>.
armando-zhu-sh commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491943663


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########


Review Comment:
   Updated and tests passed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3 [opendal]

Posted by "armando-zhu-sh (via GitHub)" <gi...@apache.org>.
armando-zhu-sh commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491943663


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########


Review Comment:
   Updated and tests passed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3 [opendal]

Posted by "ArmandoZ (via GitHub)" <gi...@apache.org>.
ArmandoZ commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491944000


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########


Review Comment:
   Updated and tests passed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: Add hdfs test case for s3(#4168) [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4184:
URL: https://github.com/apache/opendal/pull/4184#discussion_r1491883697


##########
.github/services/hdfs/hdfs_default_s3/action.yml:
##########


Review Comment:
   This setup could be named after `hdfs_default_on_minio_s3`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org