[jira] [Updated] (FLINK-14926) Make sure no resource leak of RocksObject

["Yu Li (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Li updated FLINK-14926:
--------------------------
    Release Note: After FLINK-14926, we have introduced RocksDBOptionsFactory and ConfigurableRocksDBOptionsFactory interfaces to better handle RocksObject created in PredefinedOptions and customized factories. The old OptionsFactory and ConfigurableOptionsFactory interfaces are deprecated and planned to be removed in the future.

Adding release note about deprecation of {{OptionsFactory}} and {{ConfigurableOptionsFactory}}, as well as the newly introduced {{RocksDBOptionsFactory}} and {{ConfigurableRocksDBOptionsFactory}} interfaces.

> Make sure no resource leak of RocksObject
> -----------------------------------------
>
>                 Key: FLINK-14926
>                 URL: https://issues.apache.org/jira/browse/FLINK-14926
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / State Backends
>    Affects Versions: 1.6.4, 1.7.2, 1.8.2, 1.9.1
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When investigating FLINK-14484 to allow setting {{WriteBufferManager}} via options, we find it necessary to supply a {{close}} method in {{OptionsFactory}} to make sure resources configured in options like {{WriteBufferManager}} could/would be released.
> What's more, we're having potential risk of resource leak in {{PredefinedOptions}} such as the created [BloomFilter instance|https://github.com/apache/flink/blob/e14bd50fed42e89674ba9d01a231d5c5e59f490c/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L155] is never closed (regression caused by FLINK-7220 changes), and we should also fix this and add a {{close}} method in {{PredefinedOptions}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)